Skip to content

fix(sync): harden pre-Vista condition waiters - #1960

Open
jpnurmi wants to merge 2 commits into
masterfrom
jpnurmi/fix/prevista-sync
Open

fix(sync): harden pre-Vista condition waiters#1960
jpnurmi wants to merge 2 commits into
masterfrom
jpnurmi/fix/prevista-sync

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Fix the pre-Vista condition-variable fallback so waiter accounting is incremented before the critical section is released, and waiter counts are read atomically before wake decisions.

The following review comments pointed out non-threadpool-related issues:

#skip-changelog

Comment thread src/sentry_sync.h Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/fix/prevista-sync branch from 9218a7f to 614de79 Compare August 5, 2026 11:56
@jpnurmi jpnurmi changed the title jpnurmi/fix/prevista sync fix(sync): harden pre-Vista condition waiters Aug 5, 2026
@jpnurmi
jpnurmi requested a review from JoshuaMoelans August 5, 2026 12:26
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.96%. Comparing base (58a511a) to head (614de79).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1960   +/-   ##
=======================================
  Coverage   75.95%   75.96%           
=======================================
  Files          94       94           
  Lines       22161    22161           
  Branches     3936     3936           
=======================================
+ Hits        16833    16835    +2     
+ Misses       4442     4439    -3     
- Partials      886      887    +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant