fix(sync): harden pre-Vista condition waiters - #1960
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
jpnurmi
force-pushed
the
jpnurmi/fix/prevista-sync
branch
from
August 5, 2026 11:56
9218a7f to
614de79
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
=======================================
Coverage 75.95% 75.96%
=======================================
Files 94 94
Lines 22161 22161
Branches 3936 3936
=======================================
+ Hits 16833 16835 +2
+ Misses 4442 4439 -3
- Partials 886 887 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the pre-Vista condition-variable fallback so waiter accounting is incremented before the critical section is released, and waiter counts are read atomically before wake decisions.
The following review comments pointed out non-threadpool-related issues:
cursor: "PREVISTA wake-all can deadlock"
feat(internal): thread pool #1883 (comment)
sentry: "non-atomic read of ConditionVariable->Waiters"
feat(internal): thread pool #1883 (comment)
#skip-changelog