Skip to content

fix(skill-drift): remove add_reviewer step that fails on scheduled runs#116

Merged
HazAT merged 1 commit into
mainfrom
fix/skill-drift-remove-add-reviewer
May 4, 2026
Merged

fix(skill-drift): remove add_reviewer step that fails on scheduled runs#116
HazAT merged 1 commit into
mainfrom
fix/skill-drift-remove-add-reviewer

Conversation

@HazAT
Copy link
Copy Markdown
Member

@HazAT HazAT commented May 4, 2026

Why

The most recent SDK Skill Drift Detector run failed:
run 25321035855.

The agent itself worked fine — it created PR #111 and 4 issues (#112#115). What turned the job red was the add_reviewer safe output:

add_reviewer: No pull_request_number provided and not in pull request context

The workflow runs on schedule: (cron), so there is no PR context, and the agent has no way to attach add_reviewer to the PR it just created in the same job — add_reviewer requires either a PR-event trigger or an explicit pull_request_number, neither of which is available here.

What changes

  • Drop add-reviewer: from safe-outputs: in .github/workflows/skill-drift-check.md.
  • Remove Step 4a item 5 (the instruction that told the agent to call add_reviewer).
  • Add a short note pointing the agent at the dedicated reviewer-assignment workflow so it doesn't try to assign reviewers itself.
  • Recompile skill-drift-check.lock.yml with gh-aw v0.71.1 (was v0.67.1) so CI picks up the latest compiler, pinned action SHAs, and bug fixes (notably protected-files object-form, pull_request step ordering, incremental max_patch_size measurement).

Why removing this is safe

Reviewer assignment is not lost: .github/workflows/skill-drift-assign-reviewers.yml already exists and maps each changed skills/sentry-*-sdk/** directory to its specific team owner — strictly more granular than the agent's union-of-teams approach.

Heads-up — separate issue not fixed here

The assign-reviewers workflow does not currently fire for these auto-created PRs, because gh-aw opens PRs using the default GITHUB_TOKEN, which by design does not trigger downstream pull_request events (GitHub's loop-prevention rule). Confirmed by gh run list --branch fix/skill-drift-2026-05-04-affc010fce0c14ce returning empty, and by the assign-reviewers workflow's lifetime history showing only 2 skipped runs.

That means today's effective behavior is "no reviewers assigned at all" on skill-drift PRs. To fix that properly we'd need either:

  1. Configure gh-aw's create-pull-request to use a PAT/app token so pull_request events actually fire, or
  2. Switch skill-drift-assign-reviewers.yml to a workflow_run trigger of skill-drift-check.lock.yml and have it enumerate open skill-drift-labeled PRs.

Filing this separately keeps the PR scoped to "stop the job from going red".

Verification

  • grep -c "add_reviewer\|add-reviewer" .github/workflows/skill-drift-check.lock.yml0
  • Lock file metadata: compiler_version: v0.71.1
  • gh aw compile1 workflow(s): 0 error(s), 0 warning(s)

The Weekly SDK Skill Drift Detector workflow runs on a `schedule:`
trigger, so there is no `pull_request` context. The agent's `add_reviewer`
safe output therefore failed every run with:

    add_reviewer: No pull_request_number provided and not in pull request context

turning the job red even when the PR and issues were created successfully
(see run https://github.com/getsentry/sentry-for-ai/actions/runs/25321035855).

The step was also redundant: `.github/workflows/skill-drift-assign-reviewers.yml`
already maps changed `skills/sentry-*-sdk/**` paths to the correct team and
requests review per skill (more granular than the agent's union-of-teams call).

Changes:
- Drop `add-reviewer:` from the `safe-outputs:` block.
- Remove Step 4a item 5 telling the agent to call `add_reviewer`.
- Add a short note pointing the agent at the dedicated reviewer-assignment
  workflow so it knows not to try to assign reviewers itself.
- Recompile `skill-drift-check.lock.yml` with gh-aw v0.71.1 (was v0.67.1) so
  CI uses the latest compiler and pinned actions.

Note: the assign-reviewers workflow does not currently fire for these PRs
because gh-aw opens them with `GITHUB_TOKEN`, which by design does not
trigger downstream `pull_request` events. That is a separate issue and is
not addressed here.

Co-Authored-By: Claude <noreply@anthropic.com>
@HazAT HazAT merged commit fb398fd into main May 4, 2026
9 checks passed
@HazAT HazAT deleted the fix/skill-drift-remove-add-reviewer branch May 4, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant