fix(skill-drift): remove add_reviewer step that fails on scheduled runs#116
Merged
Conversation
The Weekly SDK Skill Drift Detector workflow runs on a `schedule:`
trigger, so there is no `pull_request` context. The agent's `add_reviewer`
safe output therefore failed every run with:
add_reviewer: No pull_request_number provided and not in pull request context
turning the job red even when the PR and issues were created successfully
(see run https://github.com/getsentry/sentry-for-ai/actions/runs/25321035855).
The step was also redundant: `.github/workflows/skill-drift-assign-reviewers.yml`
already maps changed `skills/sentry-*-sdk/**` paths to the correct team and
requests review per skill (more granular than the agent's union-of-teams call).
Changes:
- Drop `add-reviewer:` from the `safe-outputs:` block.
- Remove Step 4a item 5 telling the agent to call `add_reviewer`.
- Add a short note pointing the agent at the dedicated reviewer-assignment
workflow so it knows not to try to assign reviewers itself.
- Recompile `skill-drift-check.lock.yml` with gh-aw v0.71.1 (was v0.67.1) so
CI uses the latest compiler and pinned actions.
Note: the assign-reviewers workflow does not currently fire for these PRs
because gh-aw opens them with `GITHUB_TOKEN`, which by design does not
trigger downstream `pull_request` events. That is a separate issue and is
not addressed here.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The most recent SDK Skill Drift Detector run failed:
run 25321035855.
The agent itself worked fine — it created PR #111 and 4 issues (#112–#115). What turned the job red was the
add_reviewersafe output:The workflow runs on
schedule:(cron), so there is no PR context, and the agent has no way to attachadd_reviewerto the PR it just created in the same job —add_reviewerrequires either a PR-event trigger or an explicitpull_request_number, neither of which is available here.What changes
add-reviewer:fromsafe-outputs:in.github/workflows/skill-drift-check.md.add_reviewer).skill-drift-check.lock.ymlwithgh-aw v0.71.1(wasv0.67.1) so CI picks up the latest compiler, pinned action SHAs, and bug fixes (notablyprotected-filesobject-form,pull_requeststep ordering, incrementalmax_patch_sizemeasurement).Why removing this is safe
Reviewer assignment is not lost:
.github/workflows/skill-drift-assign-reviewers.ymlalready exists and maps each changedskills/sentry-*-sdk/**directory to its specific team owner — strictly more granular than the agent's union-of-teams approach.Heads-up — separate issue not fixed here
The assign-reviewers workflow does not currently fire for these auto-created PRs, because
gh-awopens PRs using the defaultGITHUB_TOKEN, which by design does not trigger downstreampull_requestevents (GitHub's loop-prevention rule). Confirmed bygh run list --branch fix/skill-drift-2026-05-04-affc010fce0c14cereturning empty, and by the assign-reviewers workflow's lifetime history showing only 2skippedruns.That means today's effective behavior is "no reviewers assigned at all" on skill-drift PRs. To fix that properly we'd need either:
gh-aw'screate-pull-requestto use a PAT/app token sopull_requestevents actually fire, orskill-drift-assign-reviewers.ymlto aworkflow_runtrigger ofskill-drift-check.lock.ymland have it enumerate openskill-drift-labeled PRs.Filing this separately keeps the PR scoped to "stop the job from going red".
Verification
grep -c "add_reviewer\|add-reviewer" .github/workflows/skill-drift-check.lock.yml→0compiler_version: v0.71.1gh aw compile→1 workflow(s): 0 error(s), 0 warning(s)