Skip to content

feat(ci): add framework architecture validation and verification#7915

Merged
philprime merged 1 commit into
mainfrom
philprime/add-framework-verification
May 19, 2026
Merged

feat(ci): add framework architecture validation and verification#7915
philprime merged 1 commit into
mainfrom
philprime/add-framework-verification

Conversation

@philprime
Copy link
Copy Markdown
Member

@philprime philprime commented May 19, 2026

Adds a new validate-xcframework-architectures.sh script that verifies each XCFramework slice contains exactly the architectures declared in its Info.plist. This catches build misconfigurations (e.g. missing arm64e, wrong simulator archs) before the framework ships.

Architecture validation script

Parses the XCFramework Info.plist, resolves the binary path for each library entry (supporting both .framework bundles and bare libraries, including versioned macOS layouts), and compares lipo -archs output against the declared SupportedArchitectures. Runs in both CI (assemble-xcframework-variant.yml) and local builds (build-xcframework-local.sh).

Build script improvements

Refactors build-xcframework-slice.sh to use bash arrays for xcodebuild arguments instead of long inline invocations. Adds explicit generic/platform= destinations for macOS and Mac Catalyst builds to ensure correct architecture selection. Fixes OTHER_LDFLAGS handling to append -make_mergeable rather than overwrite existing flags. Also adds codesign --verify after signing and supports comma-separated SDK lists in build-xcframework-variant.sh.

Extracted from #7598

#skip-changelog

@philprime philprime marked this pull request as ready for review May 19, 2026 08:43
@philprime philprime self-assigned this May 19, 2026
@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label May 19, 2026
@philprime philprime enabled auto-merge (squash) May 19, 2026 08:44
@github-actions
Copy link
Copy Markdown
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e5b40c8

@github-actions
Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.37 ms 1249.90 ms 28.53 ms
Size 24.14 KiB 1.16 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c67ced3 1223.22 ms 1256.15 ms 32.93 ms
44b7b59 1211.91 ms 1248.90 ms 36.99 ms
ffb6adc 1218.60 ms 1247.47 ms 28.87 ms
37fd1b7 1227.56 ms 1262.45 ms 34.89 ms
787537a 1218.35 ms 1251.72 ms 33.38 ms
92bcc8f 1233.43 ms 1270.20 ms 36.77 ms
65c13c5 1234.47 ms 1263.10 ms 28.63 ms
53097d6 1218.02 ms 1251.70 ms 33.68 ms
8180609 1214.67 ms 1243.36 ms 28.69 ms
ce900e7 1212.40 ms 1244.57 ms 32.18 ms

App size

Revision Plain With Sentry Diff
c67ced3 24.14 KiB 1.16 MiB 1.13 MiB
44b7b59 24.14 KiB 1.15 MiB 1.13 MiB
ffb6adc 24.14 KiB 1.15 MiB 1.12 MiB
37fd1b7 24.14 KiB 1.15 MiB 1.13 MiB
787537a 24.14 KiB 1.15 MiB 1.12 MiB
92bcc8f 24.14 KiB 1.15 MiB 1.13 MiB
65c13c5 24.14 KiB 1.15 MiB 1.12 MiB
53097d6 24.14 KiB 1.16 MiB 1.13 MiB
8180609 24.14 KiB 1.16 MiB 1.13 MiB
ce900e7 24.14 KiB 1.15 MiB 1.13 MiB

@philprime philprime merged commit 962c7bc into main May 19, 2026
223 of 238 checks passed
@philprime philprime deleted the philprime/add-framework-verification branch May 19, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants