feat(ci): add framework architecture validation and verification#7915
Merged
Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c67ced3 | 1223.22 ms | 1256.15 ms | 32.93 ms |
| 44b7b59 | 1211.91 ms | 1248.90 ms | 36.99 ms |
| ffb6adc | 1218.60 ms | 1247.47 ms | 28.87 ms |
| 37fd1b7 | 1227.56 ms | 1262.45 ms | 34.89 ms |
| 787537a | 1218.35 ms | 1251.72 ms | 33.38 ms |
| 92bcc8f | 1233.43 ms | 1270.20 ms | 36.77 ms |
| 65c13c5 | 1234.47 ms | 1263.10 ms | 28.63 ms |
| 53097d6 | 1218.02 ms | 1251.70 ms | 33.68 ms |
| 8180609 | 1214.67 ms | 1243.36 ms | 28.69 ms |
| ce900e7 | 1212.40 ms | 1244.57 ms | 32.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c67ced3 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 44b7b59 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| ffb6adc | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 37fd1b7 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 787537a | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 92bcc8f | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 65c13c5 | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| 53097d6 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| 8180609 | 24.14 KiB | 1.16 MiB | 1.13 MiB |
| ce900e7 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
NinjaLikesCheez
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
validate-xcframework-architectures.shscript that verifies each XCFramework slice contains exactly the architectures declared in itsInfo.plist. This catches build misconfigurations (e.g. missing arm64e, wrong simulator archs) before the framework ships.Architecture validation script
Parses the XCFramework
Info.plist, resolves the binary path for each library entry (supporting both.frameworkbundles and bare libraries, including versioned macOS layouts), and compareslipo -archsoutput against the declaredSupportedArchitectures. Runs in both CI (assemble-xcframework-variant.yml) and local builds (build-xcframework-local.sh).Build script improvements
Refactors
build-xcframework-slice.shto use bash arrays for xcodebuild arguments instead of long inline invocations. Adds explicitgeneric/platform=destinations for macOS and Mac Catalyst builds to ensure correct architecture selection. FixesOTHER_LDFLAGShandling to append-make_mergeablerather than overwrite existing flags. Also addscodesign --verifyafter signing and supports comma-separated SDK lists inbuild-xcframework-variant.sh.Extracted from #7598
#skip-changelog