Skip to content

fix: Crash with AVAssetDownloadTask in setState #7891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philprime merged 5 commits into from
May 11, 2026
+8 −4
Merged

fix: Crash with AVAssetDownloadTask in setState #7891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b07b39
fix: Crash with AVAssetDownloadTask in setState
itaybre May 8, 2026
aaa25e8
fix: Add changelog entry for AVAssetDownloadTask crash
itaybre May 8, 2026
771c219
fix: Move changelog entry to Unreleased section
itaybre May 8, 2026
597e2f0
Merge branch 'main' into download_asset
itaybre May 8, 2026
9251432
Update changelog for AVAssetDownloadTask crash fix
itaybre May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Fix crash with AVAssetDownloadTask in urlSessionTask:setState: (#7891)

### Features

- Add Set conformance to SentryAttributeValue (#7876)
Expand Down
8 changes: 4 additions & 4 deletions Sources/Sentry/SentryNetworkTracker.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ - (void)urlSessionTask:(NSURLSessionTask *)sessionTask setState:(NSURLSessionTas
return;
}

if (![self isTaskSupported:sessionTask]) {
return;
}

#if SENTRY_TARGET_REPLAY_SUPPORTED
SentryOptions *options = SentrySDK.startOption;
NSString *urlString = sessionTask.originalRequest.URL.absoluteString;
Expand All @@ -246,10 +250,6 @@ - (void)urlSessionTask:(NSURLSessionTask *)sessionTask setState:(NSURLSessionTas
}
#endif // SENTRY_TARGET_REPLAY_SUPPORTED

if (![self isTaskSupported:sessionTask]) {
return;
}

// Suspended is not a terminal state: a task can be suspended and later resumed or
// cancelled, so we must wait for a final state before finishing the span.
if (newState == NSURLSessionTaskStateRunning || newState == NSURLSessionTaskStateSuspended) {
Expand Down
Loading