Skip to content

ref: Remove session replay environment checker and related options#7831

Merged
itaybre merged 7 commits intomainfrom
itay/remove_unreliableEnvironmentCheck
Apr 29, 2026
Merged

ref: Remove session replay environment checker and related options#7831
itaybre merged 7 commits intomainfrom
itay/remove_unreliableEnvironmentCheck

Conversation

@itaybre
Copy link
Copy Markdown
Contributor

@itaybre itaybre commented Apr 24, 2026

📜 Description

Removed all references to unreliable environment for Session Replay and checks related to this.

💡 Motivation and Context

The unreliable environment was fixed in v9.11.0 so we don't need this checks anymore

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Apr 24, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 24, 2026

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.11.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.336%. Comparing base (adef457) to head (b6e348a).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7831       +/-   ##
=============================================
- Coverage   85.367%   85.336%   -0.032%     
=============================================
  Files          490       487        -3     
  Lines        29620     29508      -112     
  Branches     12818     12770       -48     
=============================================
- Hits         25286     25181      -105     
+ Misses        4283      4278        -5     
+ Partials        51        49        -2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryReplayApi.m 56.000% <ø> (-6.069%) ⬇️
...tegrations/SessionReplay/SentrySessionReplay.swift 87.336% <ø> (-1.414%) ⬇️
...SessionReplay/SentrySessionReplayIntegration.swift 89.699% <ø> (-0.259%) ⬇️
Sources/Swift/SentryDependencyContainer.swift 97.272% <ø> (-0.013%) ⬇️
Sources/Swift/SentryExperimentalOptions.swift 66.666% <ø> (-8.334%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adef457...b6e348a. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.19 ms 1257.15 ms 37.96 ms
Size 24.14 KiB 1.15 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b6fa517 1218.83 ms 1257.47 ms 38.63 ms
29d546e 1224.06 ms 1257.05 ms 32.98 ms
adef457 1229.45 ms 1262.67 ms 33.22 ms
787537a 1218.35 ms 1251.72 ms 33.38 ms
a7c42d9 1217.25 ms 1253.98 ms 36.73 ms
e44b6f8 1225.98 ms 1249.20 ms 23.23 ms
ffb6adc 1218.60 ms 1247.47 ms 28.87 ms
df67624 1225.12 ms 1259.90 ms 34.78 ms
ae8cece 1216.83 ms 1251.37 ms 34.55 ms
1c5ecda 1219.35 ms 1253.76 ms 34.41 ms

App size

Revision Plain With Sentry Diff
b6fa517 24.14 KiB 1.14 MiB 1.12 MiB
29d546e 24.14 KiB 1.15 MiB 1.13 MiB
adef457 24.14 KiB 1.15 MiB 1.13 MiB
787537a 24.14 KiB 1.15 MiB 1.12 MiB
a7c42d9 24.14 KiB 1.15 MiB 1.13 MiB
e44b6f8 24.14 KiB 1.15 MiB 1.13 MiB
ffb6adc 24.14 KiB 1.15 MiB 1.12 MiB
df67624 24.14 KiB 1.14 MiB 1.12 MiB
ae8cece 24.14 KiB 1.15 MiB 1.13 MiB
1c5ecda 24.14 KiB 1.15 MiB 1.12 MiB

Previous results on branch: itay/remove_unreliableEnvironmentCheck

Startup times

Revision Plain With Sentry Diff
74c0705 1183.41 ms 1221.52 ms 38.11 ms
63781c1 1216.61 ms 1247.65 ms 31.04 ms

App size

Revision Plain With Sentry Diff
74c0705 24.14 KiB 1.13 MiB 1.11 MiB
63781c1 24.14 KiB 1.13 MiB 1.11 MiB

@itaybre itaybre marked this pull request as ready for review April 24, 2026 14:46
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f29b04d. Configure here.

Comment thread .github/workflows/test-cross-platform.yml Outdated
Comment thread Sources/Swift/SentryExperimentalOptions.swift
Copy link
Copy Markdown
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in today's Apple SDK sync, we are moving forward with this change and @itaybre will update the changelog with a warning, explaining that we are moving away from a double opt-in (setting sessionReplaySampleRate to a value higher than 0.0 and setting enableSessionReplayInUnreliableEnvironment to true) back to a single opt-in (setting sessionReplaySampleRate to a value higher than 0.0), but also including a reference how SDK users can implement the check for liquid glass in their SDK start configuration block.

@itaybre itaybre enabled auto-merge (squash) April 29, 2026 13:25
@itaybre itaybre merged commit 71e6611 into main Apr 29, 2026
207 checks passed
@itaybre itaybre deleted the itay/remove_unreliableEnvironmentCheck branch April 29, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants