ref: Remove session replay environment checker and related options#7831
ref: Remove session replay environment checker and related options#7831
Conversation
📲 Install BuildsiOS
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7831 +/- ##
=============================================
- Coverage 85.367% 85.336% -0.032%
=============================================
Files 490 487 -3
Lines 29620 29508 -112
Branches 12818 12770 -48
=============================================
- Hits 25286 25181 -105
+ Misses 4283 4278 -5
+ Partials 51 49 -2
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b6fa517 | 1218.83 ms | 1257.47 ms | 38.63 ms |
| 29d546e | 1224.06 ms | 1257.05 ms | 32.98 ms |
| adef457 | 1229.45 ms | 1262.67 ms | 33.22 ms |
| 787537a | 1218.35 ms | 1251.72 ms | 33.38 ms |
| a7c42d9 | 1217.25 ms | 1253.98 ms | 36.73 ms |
| e44b6f8 | 1225.98 ms | 1249.20 ms | 23.23 ms |
| ffb6adc | 1218.60 ms | 1247.47 ms | 28.87 ms |
| df67624 | 1225.12 ms | 1259.90 ms | 34.78 ms |
| ae8cece | 1216.83 ms | 1251.37 ms | 34.55 ms |
| 1c5ecda | 1219.35 ms | 1253.76 ms | 34.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b6fa517 | 24.14 KiB | 1.14 MiB | 1.12 MiB |
| 29d546e | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| adef457 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 787537a | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| a7c42d9 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| e44b6f8 | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| ffb6adc | 24.14 KiB | 1.15 MiB | 1.12 MiB |
| df67624 | 24.14 KiB | 1.14 MiB | 1.12 MiB |
| ae8cece | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 1c5ecda | 24.14 KiB | 1.15 MiB | 1.12 MiB |
Previous results on branch: itay/remove_unreliableEnvironmentCheck
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 74c0705 | 1183.41 ms | 1221.52 ms | 38.11 ms |
| 63781c1 | 1216.61 ms | 1247.65 ms | 31.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 74c0705 | 24.14 KiB | 1.13 MiB | 1.11 MiB |
| 63781c1 | 24.14 KiB | 1.13 MiB | 1.11 MiB |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f29b04d. Configure here.
philprime
left a comment
There was a problem hiding this comment.
As discussed in today's Apple SDK sync, we are moving forward with this change and @itaybre will update the changelog with a warning, explaining that we are moving away from a double opt-in (setting sessionReplaySampleRate to a value higher than 0.0 and setting enableSessionReplayInUnreliableEnvironment to true) back to a single opt-in (setting sessionReplaySampleRate to a value higher than 0.0), but also including a reference how SDK users can implement the check for liquid glass in their SDK start configuration block.

📜 Description
Removed all references to unreliable environment for Session Replay and checks related to this.
💡 Motivation and Context
The unreliable environment was fixed in v9.11.0 so we don't need this checks anymore
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.