feat(network-details): Implement header and body extraction by 43jay · Pull Request #7585 · getsentry/sentry-cocoa

43jay · 2026-03-04T04:28:34Z

📜 Description

`SentryNetworkBody`

Extract request/response bodies that are either JSON, formurlencoded, binary or text.

Relies on having a contentType to decide how to interpret the body (NSData).
Relies on iOS's UTType to decide whether something is JSON or text.

text:
tries .utf8 , then .isoLatin1 then gives up with BODY_PARSE_ERROR warning.

json:
tries JSONSerialization.jsonObject, gives up with BODY_PARSE_ERROR warning

UTType doesn't know:
extracts a placeholder body E.g. "[Body not captured: contentType=application/octet-stream (10240 bytes)]"

`SentryReplayNetworkRequestOrResponse`

case-insensitive header extraction

💡 Motivation and Context

See first PR in stack.

💚 How did you test it?

Unit tests

make test-ios ONLY_TESTING="SentryReplayNetworkDetailsBodyTests,SentryReplayNetworkDetailsHeaderTests,SentryReplayNetworkDetailsIntegrationTests"

Test Suite 'SentryReplayNetworkDetailsBodyTests' started at 2026-03-19 15:25:09.315.
✔ testInit_withBinaryContentType_shouldCreateArtificialString (0.005 seconds)
✔ testInit_withEmptyData_shouldReturnNil (0.000 seconds)
✔ testInit_withFormURLEncoded_duplicateKeys_shouldPromoteToArray (0.001 seconds)
✔ testInit_withFormURLEncoded_emptyKeys_shouldBeSkipped (0.000 seconds)
✔ testInit_withFormURLEncoded_emptyValue_shouldParseAsEmptyString (0.000 seconds)
Resolving Package Graph
✔ testInit_withFormURLEncoded_equalsInValue_shouldPreserve (0.000 seconds)
✔ testInit_withFormURLEncoded_missingEquals_shouldFallbackToText (0.001 seconds)
✔ testInit_withFormURLEncoded_shouldParseAsForm (0.001 seconds)
✔ testInit_withInvalidJSON_shouldFallbackToString (0.001 seconds)
✔ testInit_withJSONArray_shouldParseCorrectly (0.000 seconds)
✔ testInit_withJSONDictionary_shouldParseCorrectly (0.001 seconds)
✔ testInit_withLargeData_shouldTruncate (0.005 seconds)
✔ testInit_withNilContentType_shouldCreatePlaceholder (0.000 seconds)
✔ testInit_withTextData_shouldStoreAsString (0.000 seconds)
✔ testInit_withUnrecognizedContentType_shouldCreatePlaceholder (0.000 seconds)
✔ testParseMimeAndEncoding_shouldHandleEdgeCases (0.001 seconds)
✔ testSerialize_withJSONArray_shouldReturnArray (0.001 seconds)
✔ testSerialize_withJSONDictionary_shouldReturnDictionary (0.001 seconds)
✔ testSerialize_withNoContentType_shouldCreatePlaceholder (0.001 seconds)
✔ testSerialize_withStringBody_shouldReturnDictionary (0.001 seconds)
Executed 20 tests, with 0 failures (0 unexpected) in 0.021 (0.041) seconds
Test Suite 'SentryTests.xctest' passed at 2026-03-19 15:25:09.356.
Executed 20 tests, with 0 failures (0 unexpected) in 0.021 (0.041) seconds

SentryReplayNetworkDetailsHeaderTests (4 tests):

testExtractHeaders_withNilInputs_returnsEmptyDict — nil headers/config returns empty
testExtractHeaders_unconfiguredHeadersAreExcluded — only configured headers are extracted
testExtractHeaders_caseInsensitiveMatching — header matching is case-insensitive
testExtractHeaders_nonStringValues_convertedToStrings — non-string header values are converted

SentryReplayNetworkDetailsIntegrationTests (4 tests):

testInit_withMethod_shouldSetMethod — HTTP method is stored
testSerialize_withFullData_shouldReturnCompleteDictionary — full detail serializes all fields
testSerialize_withPartialData_shouldOnlyIncludeSetFields — partial data omits unset fields
testSerialize_withHeaderFiltering_shouldOnlyIncludeConfiguredHeaders — header filtering works end-to-end

📝 Checklist

You have to check all boxes before merging:

I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled. N/A
I updated the docs if needed. future PR
I updated the wizard if needed. N/A
Review from the native team if needed.
No breaking change or entry added to the changelog. #skip-changelog future PR
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Closes #7710

linear · 2026-03-04T04:28:37Z

MOBILE-935 [Mobile Replay] Capture Network request/response bodies

github-actions · 2026-03-04T04:28:50Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-03-04T04:29:03Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d0b9491

codecov · 2026-03-04T04:39:01Z

Codecov Report

❌ Patch coverage is 97.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.409%. Comparing base (6baf12d) to head (d0b9491).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ons/SessionReplay/SentryReplayNetworkDetails.swift	97.000%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #7585       +/-   ##
=============================================
+ Coverage   85.186%   85.409%   +0.223%     
=============================================
  Files          490       490               
  Lines        29520     29616       +96     
  Branches     12761     12813       +52     
=============================================
+ Hits         25147     25295      +148     
+ Misses        4322      4269       -53     
- Partials        51        52        +1

Files with missing lines	Coverage Δ
...ons/SessionReplay/SentryReplayNetworkDetails.swift	`96.644% <97.000%> (+96.644%)`	⬆️

... and 8 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6baf12d...d0b9491. Read the comment docs.

sentry · 2026-04-28T20:24:32Z

📲 Install Builds

iOS

🔗 App Name	App ID	Version	Configuration
SDK-Size	io.sentry.sample.SDK-Size	9.11.0 (1)	Release

⚙️ sentry-cocoa Build Distribution Settings

github-actions · 2026-04-28T21:29:05Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1228.73 ms	1248.05 ms	19.31 ms
Size	24.14 KiB	1.15 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`787537a`	1218.35 ms	1251.72 ms	33.38 ms
`ffb6adc`	1218.60 ms	1247.47 ms	28.87 ms
`b6fa517`	1218.83 ms	1257.47 ms	38.63 ms
`df67624`	1225.12 ms	1259.90 ms	34.78 ms
`a7c42d9`	1217.25 ms	1253.98 ms	36.73 ms
`29d546e`	1224.06 ms	1257.05 ms	32.98 ms
`1c5ecda`	1219.35 ms	1253.76 ms	34.41 ms
`ae8cece`	1216.83 ms	1251.37 ms	34.55 ms

App size

Revision	Plain	With Sentry	Diff
`787537a`	24.14 KiB	1.15 MiB	1.12 MiB
`ffb6adc`	24.14 KiB	1.15 MiB	1.12 MiB
`b6fa517`	24.14 KiB	1.14 MiB	1.12 MiB
`df67624`	24.14 KiB	1.14 MiB	1.12 MiB
`a7c42d9`	24.14 KiB	1.15 MiB	1.13 MiB
`29d546e`	24.14 KiB	1.15 MiB	1.13 MiB
`1c5ecda`	24.14 KiB	1.15 MiB	1.12 MiB
`ae8cece`	24.14 KiB	1.15 MiB	1.13 MiB

Previous results on branch: mobile-935/extract-network-details

Startup times

Revision	Plain	With Sentry	Diff
`0390710`	1214.67 ms	1245.27 ms	30.60 ms
`ef5b57a`	1226.96 ms	1259.79 ms	32.83 ms
`00b9497`	1212.87 ms	1240.63 ms	27.76 ms
`4a5e66b`	1228.77 ms	1254.27 ms	25.50 ms

App size

Revision	Plain	With Sentry	Diff
`0390710`	24.14 KiB	1.15 MiB	1.13 MiB
`ef5b57a`	24.14 KiB	1.15 MiB	1.12 MiB
`00b9497`	24.14 KiB	1.15 MiB	1.13 MiB
`4a5e66b`	24.14 KiB	1.15 MiB	1.13 MiB

43jay · 2026-04-29T01:27:31Z

rebase on main

1) Extracts bodies that are JSON, formurlencoded, or text. Uses UTType to accurately classify content types as JSON or text without maintaining a manual list. Falls back to a string match for application/x-www-form-urlencoded which has no UTType representation. !Relies on having a valid `contentType` 2) Populates NetworkBodyWarning's for "MAYBE_JSON_TRUNCATED" "TEXT_TRUNCATED" "BODY_PARSE_ERROR" ^when encountered, these show custom dashboard UI.

Uses UTType to classify content types: only content positively identified as text is decoded. Everything else gets a descriptive placeholder: Example - "[Body not captured: contentType=image/png (8 bytes)]" Known text types (where UTType conforms to .text) are reliably classified by UTType's type hierarchy. If a content type header is incorrect (e.g. claims text but contains binary), the resulting decode failure is caught by the existing bodyParseError warning.

@available

UTType (UniformTypeIdentifiers) requires macOS 11+, but the SDK targets macOS 10.14. Extract UTType-based MIME detection into a separate method gated with @available(macOS 11, *) so the code compiles on all macOS targets. Session Replay is not available on macOS, so the fallback placeholder is fine.

Casts to lower-case before comparing headers. ObjC setters now accept raw allHeaders and configuredHeaders instead of pre-filtered headers, keeping the filtering logic in Swift.

https://github.com/getsentry/sentry-cocoa/pull/7585/changes/BASE..fbd791c4c99aa01bb7569676581f041fdc3d5607#r2930818428

#7585 (comment) Parse MIME type and charset from Content-Type using CFStringConvertIANACharSetNameToEncoding instead of hardcoding UTF-8/ISO-Latin-1 fallbacks.

https://github.com/getsentry/sentry-cocoa/pull/7585/changes#r2930837895

https://github.com/getsentry/sentry-cocoa/pull/7585/changes/BASE..e586a59490c8d037efcb8b0d77e70125844cf01b#r2942848763

…m-urlencoded based on https://github.com/kula-app/Postie/blob/3698c01e4c2df68d81a23b4dc428416cea9e4e5f/Sources/URLEncodedFormCoding/URLEncodedFormDecoder.swift#L19-L49 extended unit tests

…oundaries #7585 (comment)

#7585 (comment)

Replace force-unwraps and if-let/XCTFail patterns in SentryReplayNetworkDetailsBodyTests with XCTUnwrap for optional casts and Data(_:) for String-to-Data conversions.

43jay marked this pull request as ready for review March 4, 2026 04:31

43jay requested review from itaybre, noahsmartin, philipphofmann and philprime as code owners March 4, 2026 04:32

github-actions Bot mentioned this pull request Mar 4, 2026

feat(network-details): Implement header and body extraction #7586

Closed

7 tasks

sentry Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread Sources/Sentry/SentryNetworkBody.m Outdated

Comment thread Sources/Sentry/SentryNetworkBody.m Outdated

cursor Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread Sources/Sentry/SentryNetworkBody.m Outdated

Comment thread Sources/Sentry/SentryNetworkBodyWarning.m Outdated

github-actions Bot mentioned this pull request Mar 4, 2026

feat(network-details): Implement header and body extraction #7587

Closed

7 tasks

43jay mentioned this pull request Mar 4, 2026

feat(network-details): Extend SentryReplayOptions API with Session Replay Network Details configuration #7580

Merged

7 tasks

43jay force-pushed the mobile-935/new-swizzling branch from 9473efb to 5bc5830 Compare March 4, 2026 21:03

43jay force-pushed the mobile-935/extract-network-details branch 2 times, most recently from 3547546 to e7c5abb Compare March 4, 2026 22:00

43jay force-pushed the mobile-935/new-swizzling branch 2 times, most recently from 7faf4ef to 6e19c0a Compare March 6, 2026 16:33

43jay force-pushed the mobile-935/extract-network-details branch from e7c5abb to 2e9607e Compare March 6, 2026 16:33

cursor Bot reviewed Mar 6, 2026

View reviewed changes

Comment thread Sources/Swift/Integrations/SessionReplay/SentryReplayNetworkDetails.swift Outdated

43jay marked this pull request as draft March 6, 2026 18:43

43jay force-pushed the mobile-935/new-swizzling branch from 6e19c0a to 9a8d48d Compare March 6, 2026 19:25

43jay force-pushed the mobile-935/extract-network-details branch 2 times, most recently from 6e5c5bb to 41cf944 Compare March 9, 2026 18:09

43jay force-pushed the mobile-935/new-swizzling branch from 9a8d48d to 8584657 Compare March 9, 2026 18:09

43jay force-pushed the mobile-935/extract-network-details branch from 41cf944 to 68fbe88 Compare March 9, 2026 19:02

43jay force-pushed the mobile-935/new-swizzling branch 2 times, most recently from c3afd6d to 6e873ec Compare March 9, 2026 19:48

43jay force-pushed the mobile-935/extract-network-details branch from 68fbe88 to 6a06365 Compare March 9, 2026 19:48

itaybre added the ready-to-merge Use this label to trigger all PR workflows label Apr 28, 2026

43jay force-pushed the mobile-935/extract-network-details branch from c73b24f to dc3a7af Compare April 28, 2026 20:58

43jay force-pushed the mobile-935/extract-network-details branch from dc3a7af to 5372649 Compare April 28, 2026 21:40

sentry Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread Sources/Swift/Integrations/SessionReplay/SentryReplayNetworkDetails.swift

43jay force-pushed the mobile-935/extract-network-details branch from 5372649 to c1488f7 Compare April 28, 2026 22:19

Base automatically changed from mobile-935/new-swizzling to main April 28, 2026 23:19

43jay force-pushed the mobile-935/extract-network-details branch from c1488f7 to 98d01fc Compare April 29, 2026 01:26

sentry Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread Sources/Swift/Integrations/SessionReplay/SentryReplayNetworkDetails.swift

43jay enabled auto-merge (squash) April 29, 2026 02:43

43jay added 12 commits April 29, 2026 06:00

feat(network-details): Extract headers

55646d7

Casts to lower-case before comparing headers. ObjC setters now accept raw allHeaders and configuredHeaders instead of pre-filtered headers, keeping the filtering logic in Swift.

review-feedback: remove if/else

0e88a89

https://github.com/getsentry/sentry-cocoa/pull/7585/changes/BASE..fbd791c4c99aa01bb7569676581f041fdc3d5607#r2930818428

review-comment: Extract charset from Content-Type header

8dc9b06

#7585 (comment) Parse MIME type and charset from Content-Type using CFStringConvertIANACharSetNameToEncoding instead of hardcoding UTF-8/ISO-Latin-1 fallbacks.

review-comment: document maxBodySize constant

4ab5a49

https://github.com/getsentry/sentry-cocoa/pull/7585/changes#r2930837895

review-comment: Use correct contentType when json decoding fails

bbe46cd

https://github.com/getsentry/sentry-cocoa/pull/7585/changes/BASE..e586a59490c8d037efcb8b0d77e70125844cf01b#r2942848763

review-comment: Don't use URLComponent to parse application/x-www-for…

dfefb4e

…m-urlencoded based on https://github.com/kula-app/Postie/blob/3698c01e4c2df68d81a23b4dc428416cea9e4e5f/Sources/URLEncodedFormCoding/URLEncodedFormDecoder.swift#L19-L49 extended unit tests

review-comment: Correctly handle utf-8 truncation within multi-byte b…

1f0d3f3

…oundaries #7585 (comment)

review-comment: Fix form-urlencoded percent-decoding fallback

514b780

#7585 (comment)

review-comment: Use XCTUnwrap and Data(_:) in body tests

d0b9491

Replace force-unwraps and if-let/XCTFail patterns in SentryReplayNetworkDetailsBodyTests with XCTUnwrap for optional casts and Data(_:) for String-to-Data conversions.

43jay force-pushed the mobile-935/extract-network-details branch from 98d01fc to d0b9491 Compare April 29, 2026 10:00

43jay merged commit e44b6f8 into main Apr 29, 2026
212 of 216 checks passed

43jay deleted the mobile-935/extract-network-details branch April 29, 2026 11:06

itaybre mentioned this pull request Apr 29, 2026

feat(network-details): Add experimental flag and changelog #7854

Merged

5 tasks

github-actions Bot mentioned this pull request May 4, 2026

[skill-drift] sentry-cocoa-sdk may need updates for Session Replay Network Details getsentry/sentry-for-ai#113

Closed

mpawlo mentioned this pull request May 8, 2026

Regression in 9.12.0: crash with AVAssetDownloadTask in urlSessionTask:setState: — "does not support originalRequest property" #7886

Open

Uh oh!

Conversation

43jay commented Mar 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

SentryNetworkBody

SentryReplayNetworkRequestOrResponse

💡 Motivation and Context

💚 How did you test it?

Unit tests

📝 Checklist

Uh oh!

linear Bot commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sentry Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

iOS

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: mobile-935/extract-network-details

Startup times

App size

Uh oh!

Uh oh!

43jay commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

43jay commented Mar 4, 2026 •

edited by github-actions Bot

Loading

`SentryNetworkBody`

`SentryReplayNetworkRequestOrResponse`

github-actions Bot commented Mar 4, 2026 •

edited

Loading

github-actions Bot commented Mar 4, 2026 •

edited

Loading

codecov Bot commented Mar 4, 2026 •

edited

Loading

sentry Bot commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading