Skip to content

feat(network-details): [test-app] Add testing UI to iOS-Swift#7581

Merged
43jay merged 10 commits intomainfrom
mobile-935/ios-swift-app
Apr 27, 2026
Merged

feat(network-details): [test-app] Add testing UI to iOS-Swift#7581
43jay merged 10 commits intomainfrom
mobile-935/ios-swift-app

Conversation

@43jay
Copy link
Copy Markdown
Contributor

@43jay 43jay commented Mar 3, 2026

📜 Description

Enables network detail capture for httpbin.org:

networkDetailAllowUrls = [ "httpbin.org" ]

Adds a new screen to iOS-Swift sample app to

  • Initiate different types of network requests - JSON, form-url-encoded, text, binary.
  • Show the request/response details in the test app for easy comparison against request/response details added to session replay capture.

💡 Motivation and Context

100% coded by claude, acceptance criteria was to pass swiftlint for any code i introduced.

1) Navigating to Network Details screen from Extras
image

2) Test screen on initial load
image

3) Test Screen with request/response details populated (JSON request)
image

4) Corresponding Session Replay captured (https://sentry-sdks.sentry.io/explo...)
image

💚 How did you test it?

Build + Install

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes. N/A - test app
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled. N/A - test app
  • I updated the docs if needed. N/A - test app
  • I updated the wizard if needed. N/A - test app
  • Review from the native team if needed. N/A - test app
  • No breaking change or entry added to the changelog. N/A - test app #skip-changelog
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs. N/A - test app

@linear
Copy link
Copy Markdown

linear Bot commented Mar 3, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against dc42772

Comment thread Samples/iOS-Swift/iOS-Swift/ExtraViewController.swift Outdated
Copy link
Copy Markdown
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, left a couple of comments

Comment thread Samples/iOS-Swift/iOS-Swift/NetworkTestingViewController.swift Outdated
Comment thread Samples/iOS-Swift/App/Sources/ExtraViewController.swift
Comment thread Samples/iOS-Swift/App/Sources/NetworkTestingViewController.swift
Comment thread Samples/iOS-Swift/iOS-Swift/NetworkTestingViewController.swift Outdated
Comment thread Samples/iOS-Swift/iOS-Swift/TransactionsViewController.swift Outdated
Comment thread Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift Outdated
Comment thread Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift Outdated
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 0898913 to 240ba73 Compare March 4, 2026 21:03
Comment thread Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift Outdated
Comment thread Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift Outdated
Comment thread Samples/iOS-Swift/iOS-Swift/TransactionsViewController.swift Outdated
43jay added a commit that referenced this pull request Mar 4, 2026
@43jay
Copy link
Copy Markdown
Contributor Author

43jay commented Mar 4, 2026

@philprime PTAL 🙏

AFAICT all comments resolved except for the 'why did you not use xcode for this' ones:

@43jay 43jay requested a review from philprime March 4, 2026 22:02
Comment thread Samples/iOS-Swift/iOS-Swift/NetworkTestingViewController.swift Outdated
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from cd8e4f0 to 327fd2e Compare March 9, 2026 19:02
@43jay 43jay force-pushed the mobile-935/sdk-options branch from cfc450a to 1d0cc82 Compare March 9, 2026 19:02
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 327fd2e to faac0a4 Compare March 9, 2026 19:48
@43jay 43jay force-pushed the mobile-935/sdk-options branch from 1d0cc82 to 037f0e4 Compare March 9, 2026 19:48
Comment thread Samples/iOS-Swift/App/Sources/NetworkTestingViewController.swift
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread Samples/iOS-Swift/App/Sources/NetworkTestingViewController.swift
@43jay 43jay force-pushed the mobile-935/sdk-options branch from 037f0e4 to cad52c2 Compare March 10, 2026 21:06
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 8a5da47 to 719553e Compare March 10, 2026 21:06
@43jay 43jay force-pushed the mobile-935/sdk-options branch from cad52c2 to 83310fd Compare March 16, 2026 20:31
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 719553e to 1865d4a Compare March 16, 2026 20:31
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 1865d4a to 0100eb1 Compare April 13, 2026 17:48
@43jay 43jay force-pushed the mobile-935/sdk-options branch from 83310fd to 2cef0e3 Compare April 13, 2026 17:48
@43jay 43jay force-pushed the mobile-935/sdk-options branch from 2cef0e3 to ddec481 Compare April 23, 2026 19:39
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 0100eb1 to 1d4da84 Compare April 23, 2026 19:39
@43jay 43jay force-pushed the mobile-935/sdk-options branch from ddec481 to a9ab468 Compare April 27, 2026 18:25
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 1d4da84 to 2262cb6 Compare April 27, 2026 18:25
Base automatically changed from mobile-935/sdk-options to main April 27, 2026 18:49
@43jay 43jay force-pushed the mobile-935/ios-swift-app branch from 2262cb6 to 1b474b2 Compare April 27, 2026 19:24
@43jay
Copy link
Copy Markdown
Contributor Author

43jay commented Apr 27, 2026

rebase

@43jay 43jay enabled auto-merge (squash) April 27, 2026 19:25
@43jay 43jay added the ready-to-merge Use this label to trigger all PR workflows label Apr 27, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 27, 2026

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.11.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@43jay
Copy link
Copy Markdown
Contributor Author

43jay commented Apr 27, 2026

make format; rebase

@43jay 43jay merged commit b6fa517 into main Apr 27, 2026
170 checks passed
@43jay 43jay deleted the mobile-935/ios-swift-app branch April 27, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants