Skip to content

fix(playstation): Add overall stream size limit#5795

Merged
elramen merged 2 commits intomasterfrom
ps3
Apr 9, 2026
Merged

fix(playstation): Add overall stream size limit#5795
elramen merged 2 commits intomasterfrom
ps3

Conversation

@elramen
Copy link
Copy Markdown
Member

@elramen elramen commented Apr 8, 2026

Add an overall stream size limit - max_upload_size + max_attachments_size - to playstation multiparts like there already is for minidump and attachments multiparts. This prevents overly long processing times when an oversized playstation multipart is received. Also remove related and now unused code.

Fixes INGEST-831

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

@elramen elramen marked this pull request as ready for review April 8, 2026 14:03
@elramen elramen requested a review from a team as a code owner April 8, 2026 14:03
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 36feafe. Configure here.

Comment on lines +6 to +7
pub(crate) mod common;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub so that BadStoreRequest can be used in the return type of utils::multipart::multipart_from_request. This avoids having to map the error in the 3 different endpoints using multipart.

@elramen elramen enabled auto-merge April 9, 2026 13:50
@elramen elramen added this pull request to the merge queue Apr 9, 2026
Merged via the queue into master with commit 2d94782 Apr 9, 2026
30 checks passed
@elramen elramen deleted the ps3 branch April 9, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants