Skip to content

feat: Add Linear action item syncing for incidents #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spalmurray wants to merge 29 commits into
base: main
Choose a base branch
from

Add Linear config to CI toml so action item tests run

4bc74d3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

feat: Add Linear action item syncing for incidents #139

Add Linear config to CI toml so action item tests run
4bc74d3
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: find-bugs completed Apr 14, 2026 in 6m 32s

1 issue

find-bugs: Found 1 issue (1 medium)

Medium

Missing validation for SALT_KEY when Linear integration is enabled - `src/firetower/settings.py:80`

SALT_KEY is used to encrypt OAuth tokens via django-fernet-encrypted-fields, but there's no validation ensuring it's set to a strong value when Linear is configured. The config.example.toml shows an empty default. Following the existing pattern (IAP_AUDIENCE validation at lines 297-301), the code should validate that SALT_KEY is non-empty when config.linear is configured, especially in non-dev environments. Without this, encrypted tokens may use a weaker key derivation.

Duration: 391.6s · Tokens: 3.8M in / 34.3k out · Cost: $6.90 (+extraction: $0.00)

Annotations

Check warning on line 80 in src/firetower/settings.py

See this annotation in the file changed.

@github-actions github-actions / warden: find-bugs

Missing validation for SALT_KEY when Linear integration is enabled 

SALT_KEY is used to encrypt OAuth tokens via django-fernet-encrypted-fields, but there's no validation ensuring it's set to a strong value when Linear is configured. The config.example.toml shows an empty default. Following the existing pattern (IAP_AUDIENCE validation at lines 297-301), the code should validate that SALT_KEY is non-empty when config.linear is configured, especially in non-dev environments. Without this, encrypted tokens may use a weaker key derivation.
View more details on GitHub Actions