feat: Add advanced filters panel to incident list #126
1 issue
code-review: Found 1 issue (1 medium)
Medium
Invalid 'Any' status value sent directly to backend API - `frontend/src/routes/types.ts:23`
The new STATUS_FILTER_GROUPS.all contains ['Any'] which is passed directly to the backend API as a status filter. However, 'Any' is not a valid value in StatusSchema (which only allows Active, Mitigated, Postmortem, Done, Cancelled). This will likely cause the API to reject the request or return unexpected results when users click the 'All' filter. The 'Any' value appears intended as a UI concept meaning 'no filter', but should be transformed to undefined or omitted from the API request rather than sent literally.
Duration: 107.5s · Tokens: 706.6k in / 10.8k out · Cost: $1.46 (+extraction: $0.00)
Annotations
Check warning on line 23 in frontend/src/routes/types.ts
github-actions / warden: code-review
Invalid 'Any' status value sent directly to backend API
The new `STATUS_FILTER_GROUPS.all` contains `['Any']` which is passed directly to the backend API as a status filter. However, `'Any'` is not a valid value in `StatusSchema` (which only allows Active, Mitigated, Postmortem, Done, Cancelled). This will likely cause the API to reject the request or return unexpected results when users click the 'All' filter. The 'Any' value appears intended as a UI concept meaning 'no filter', but should be transformed to `undefined` or omitted from the API request rather than sent literally.