feat: Add advanced filters panel to incident list #126
1 issue
code-review: Found 1 issue (1 medium)
Medium
"Clear all filters" unexpectedly clears the status filter - `frontend/src/routes/components/filters/FilterTrigger.tsx:18-22`
The navigate({search: {}}) call clears ALL URL search parameters, including status which is managed by the separate StatusFilter component. The activeCount from useActiveFilters() doesn't count status, so users see a badge showing only advanced filter counts but clicking 'Clear all' also resets the status tabs (Active/In Review/Closed/All) to the default. Other filter components in this PR use search: (prev) => ({...prev, ...}) to preserve unrelated params.
Duration: 173.9s · Tokens: 771.5k in / 11.6k out · Cost: $1.54 (+extraction: $0.00)
Annotations
Check warning on line 22 in frontend/src/routes/components/filters/FilterTrigger.tsx
github-actions / warden: code-review
"Clear all filters" unexpectedly clears the status filter
The `navigate({search: {}})` call clears ALL URL search parameters, including `status` which is managed by the separate StatusFilter component. The `activeCount` from `useActiveFilters()` doesn't count `status`, so users see a badge showing only advanced filter counts but clicking 'Clear all' also resets the status tabs (Active/In Review/Closed/All) to the default. Other filter components in this PR use `search: (prev) => ({...prev, ...})` to preserve unrelated params.