Skip to content

feat(testing): Support reusable prepared test artifacts#475

Merged
cameroncooke merged 24 commits into
mainfrom
codex/feat/issue-450-build-for-testing
Jul 20, 2026
Merged

feat(testing): Support reusable prepared test artifacts#475
cameroncooke merged 24 commits into
mainfrom
codex/feat/issue-450-build-for-testing

fix: remove unstable snapshot fixture churn

115fdde
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: xcodebuildmcp-test-boundary-review completed Jul 18, 2026 in 0s

2 issues

xcodebuildmcp-test-boundary-review: Found 2 issues (2 low)

Low

Sentinel count 99999 as input weakens the 'without hiding capture content' assertion - `src/snapshot-tests/__tests__/json-normalize.test.ts:282-320`

The test 'normalizes Settings.app compact capture refs without hiding capture content' is meant to prove that the count under settingsCapture/appCapture is passed through unchanged (unlike the count under a capture object, which is normalized to 99999). By setting both the raw input and the expected count to 99999 — the exact normalizer sentinel — the assertion no longer distinguishes preserved values from normalized ones: a regression that started normalizing these counts to 99999 would still pass. Use distinct non-sentinel values (e.g. 144 and 19) for input and expected so the assertion fails if normalization is ever applied to compact-capture counts.

Test silently returns and asserts nothing outside a /private/tmp macOS worktree - `src/snapshot-tests/__tests__/normalize-project-root.test.ts:8-15`

This test early-returns (with no assertion) whenever the working directory is not under /private/tmp/, so it passes vacuously on Linux CI and typical dev machines, providing no real coverage of the alias normalization; assert against an injected/constructed path or use it.skip with a clear condition instead of a silent return.


⏱ 25m 17s · 1.4M in / 53.7k out · $5.68