feat(app): add Copy PR URL to checkout dropdown#1656
Open
thgcst wants to merge 2 commits into
Open
Conversation
Adds a "Copy PR URL" item to the git actions dropdown, positioned immediately after "View PR". Tapping it copies the PR URL to the clipboard and shows a "URL copied" success toast. The dropdown closes on select. Closes getpaseo#1655
Author
Comment on lines
+130
to
+134
| "copy-pr-url": { | ||
| disabled: false, | ||
| status: "idle", | ||
| handler: () => undefined, | ||
| }, |
There was a problem hiding this comment.
No test assertions for the new action's ordering or visibility
The only change here is adding copy-pr-url to the fixture, which is required to keep existing tests compiling. There are no new test cases verifying that copy-pr-url appears immediately after pr in the secondary list, that it is absent when hasPullRequest is false, or that it is absent when pullRequestUrl is null. Given the injection logic lives in a for-loop inside buildGitActions, a policy test covering these three cases would be the natural place to pin the behavior.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #1655
What changed
Added a Copy PR URL item to the git actions dropdown, positioned immediately after View PR.
Testing
Tested on desktop web with a branch that has an open PR:
Platforms tested