fix(dev): drop unneeded cross-env from paseo.json dev scripts#1637
Open
cleiter wants to merge 1 commit into
Open
fix(dev): drop unneeded cross-env from paseo.json dev scripts#1637cleiter wants to merge 1 commit into
cleiter wants to merge 1 commit into
Conversation
When running Paseo on the Paseo repo itself, the worktree setup step and the paseo.json service scripts (daemon/app/desktop/ios-simulator) fail with "cross-env: command not found" unless cross-env is installed globally. The daemon runs paseo.json commands in a plain shell without the project's node_modules/.bin on PATH (unlike npm run), so the bare cross-env (a local devDependency) does not resolve. cross-env only exists for Windows cmd compatibility, and every one of these commands launches a unix ./scripts/*.sh, so it was not buying anything here. Drop it and set the env vars inline. The cross-env dependency stays -- it is still used by the npm run scripts where it is actually needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Paseo on the Paseo repo itself, the worktree setup step and the
paseo.jsonservice scripts (daemon/app/desktop/ios-simulator) fail withcross-env: command not foundunless cross-env is installed globally.The daemon runs
paseo.jsoncommands in a plain shell that doesn't have the project'snode_modules/.binonPATHthe waynpm rundoes, so the barecross-env(a local devDependency) doesn't resolve. It only works when the daemon itself runs from the source checkout, which is why it hasn't come up.Fix: drop
cross-envfrom these commands and set the env vars inline. cross-env only exists for Windowscmdcompatibility, and every one of these commands launches a unix./scripts/*.sh, so Windows support is already gone here — cross-env wasn't buying anything.The
cross-envdependency stays: it's still used and needed by thenpm runscripts inpackage.json/packages/app/packages/server, where commands run via npm on Windows and invoke cross-platform tools (expo, tsx, node). This change is scoped topaseo.jsononly — removedcross-envfrom 5 commands (setup + 4 services), env vars now set inline.How verified: macOS, with cross-env NOT installed globally. Created a fresh Paseo workspace and confirmed the previously-failing commands now run without cross-env — the env-setting step in worktree setup and the daemon/app service scripts launch fine. Before this change they failed with
cross-env: command not found.Discussed in #contributing: https://discordapp.com/channels/1481169421832814616/1517543045384507412