Fix max-pixels compression not applying to ImageWidget#7284
Open
grzesiek2010 wants to merge 6 commits into
Open
Fix max-pixels compression not applying to ImageWidget#7284grzesiek2010 wants to merge 6 commits into
ImageWidget#7284grzesiek2010 wants to merge 6 commits into
Conversation
ImageWidget
seadowg
requested changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7277
Why is this the best possible solution? Were any other approaches considered?
We recently refactored
ImageWidgetand detached it from the old hierarchy (it previously extendedBaseImageWidget). As a result, we now need to explicitly handle it inMediaLoadingTask, where we determine whether image compression should be triggered.This is probably not the ideal architecture (although it has been working this way for a long time), as
MediaLoadingTaskis responsible for more than just image loading. A better long-term solution would be to move the compression logic into the image widgets themselves. However, that would require a larger refactoring, and with the release just around the corner, this doesn't seem like the right time for such a change.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The fix is tiny and carries virtually no risk. A simple check to verify that compression works for basic image widgets is sufficient.
Do we need any specific form for testing your changes? If so, please attach one.
There's a form attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest