Skip to content

Use consistent image answer view in summary and widget#7279

Open
grzesiek2010 wants to merge 2 commits into
getodk:masterfrom
grzesiek2010:image_size
Open

Use consistent image answer view in summary and widget#7279
grzesiek2010 wants to merge 2 commits into
getodk:masterfrom
grzesiek2010:image_size

Conversation

@grzesiek2010

@grzesiek2010 grzesiek2010 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Why is this the best possible solution? Were any other approaches considered?

We discussed that it's better to maintain consistency in how image and video answers are displayed across different types of questions, as well as between widgets and the hierarchy view.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This should display images and videos consistently across different question types, regardless of whether they are shown in the hierarchy view or inline within widgets. Please verify that the behavior is consistent and that no regressions have been introduced. There is no need to test opening media files, as the only change is the display size of images.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with different image questions, like the All question types form.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review June 24, 2026 16:45
@grzesiek2010 grzesiek2010 requested a review from seadowg June 24, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants