Skip to content

fix: downgrade Logger.error to Logger.warning for known path-not-found failures in MediaImport #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −5
Open

fix: downgrade Logger.error to Logger.warning for known path-not-found failures in MediaImport #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions lib/mydia/jobs/media_import.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,11 @@ defmodule Mydia.Jobs.MediaImport do
process_import(download, files, args)

{:ok, []} ->
Logger.error("No files found for download", download_id: download.id)
Logger.warning("No files found for download",
download_id: download.id,
operational: true
)

{:error, :no_files}

{:error, error} ->
Expand All @@ -293,18 +297,20 @@ defmodule Mydia.Jobs.MediaImport do
process_import(download, files, args)

{:ok, []} ->
Logger.error("No files found at save_path",
Logger.warning("No files found at save_path",
download_id: download.id,
save_path: args.save_path
save_path: args.save_path,
operational: true
)

{:error, :no_files}

{:error, path_error} ->
Logger.error("save_path fallback also failed",
Logger.warning("save_path fallback also failed",
download_id: download.id,
save_path: args.save_path,
error: inspect(path_error)
error: inspect(path_error),
operational: true
)

{:error, path_error}
Expand Down Expand Up @@ -564,13 +570,28 @@ defmodule Mydia.Jobs.MediaImport do
end

File.exists?(Path.dirname(path)) ->
Logger.warning("Path not found (parent exists, leaf missing)",
path: path,
operational: true
)

{:error, {:path_not_found, path}}

true ->
Logger.warning("Path not found (parent directory not visible)",
path: path,
operational: true
)

{:error, {:path_not_found, path}}
end
rescue
_e in File.Error ->
Logger.warning("Path not accessible",
path: path,
operational: true
)

{:error, {:path_not_accessible, path}}
end

Expand Down