fix(vpn): remove deprecated endpoint-independent NAT from tun defaults#563
Conversation
`EndpointIndependentNat` is only supported on gVisor stacks and is deprecated, so drop it from the system stack tun configuration.
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe default ChangesTUN inbound configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes the deprecated EndpointIndependentNat setting from the default TUN inbound options, aligning the default system-stack configuration with current sing-box support expectations.
Changes:
- Drops
EndpointIndependentNat: truefrombaseInbounds()’sO.TunInboundOptionsdefaults. - Removes the inline rationale comment that was tied to enabling endpoint-independent NAT by default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
LGTM |
|
Thanks @atavism! |
This pull request makes a small change to the default inbound configuration in
vpn/boxoptions_default.go. TheEndpointIndependentNatoption was removed from the returned struct in thebaseInboundsfunction.EndpointIndependentNatis only supported on gVisor stacks and is deprecated, so drop it from the system stack tun configuration.Summary by CodeRabbit