deps: bump lantern-box to v0.0.99 (autoselect demote mid-stream fix)#551
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the required version of the ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: None specified. Related PRs: None specified. Suggested labels: dependencies Suggested reviewers: None specified. 🐰 A tiny hop, a version bump so neat, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
There was a problem hiding this comment.
Pull request overview
Updates Radiance’s dependency on github.com/getlantern/lantern-box to pick up fixes and newer shared runtime components described in the PR metadata (notably the autoselect demotion reset fix).
Changes:
- Bump
github.com/getlantern/lantern-boxfromv0.0.95tov0.0.99ingo.mod. - Update
go.sumchecksums to matchlantern-box v0.0.99.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Bumps github.com/getlantern/lantern-box requirement to v0.0.99. |
| go.sum | Replaces lantern-box v0.0.95 checksum entries with v0.0.99. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myleshorton
left a comment
There was a problem hiding this comment.
Looks like a build issue but otherwise lgtm
|
That's because this will bring in the WATER changes and require bumping the lantern WATER fork, which haven't been tested on all platforms, as far as I know. The build issue will be resolved once @WendelHime's PR is merged. |
Bumps
github.com/getlantern/lantern-boxfrom v0.0.95 to v0.0.99.The headline change for radiance is the autoselect fix: demoted proxies were being reset mid-stream (getlantern/lantern-box#284). The range also pulls in the shared water runtime and the meek outbound/server work landed in lantern-box between these tags.
Changes
go.mod/go.sum: lantern-box v0.0.95 → v0.0.99Summary by CodeRabbit