models: correct the lantern-box version in user_failures comments#8931
Conversation
The comments introduced in #8929 cite v0.0.104 as the release that changed each `user_failures` entry from a bare RFC3339 string to a {"at", "kind"} object. That was the edge of the module cache I sampled, not the actual boundary. Verified against the tags: v0.0.99, v0.0.100 UserFailures []time.Time v0.0.101 .. v0.0.106 UserFailures []UserFailure The change landed in lantern-box #286 (b2c28bb), first tagged v0.0.101. These comments exist to point a future reader at the version where the shape changed, so the wrong number defeats their only purpose. Comments only — no behavior change. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated ChangesSelectionHistory timestamp documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Corrects the lantern-box version referenced in user_failures documentation/comments so future readers are pointed to the actual release where the JSON shape changed (v0.0.101), without altering runtime behavior.
Changes:
- Update
user_failuresdeserialization test group comment to reference lantern-box v0.0.101 (was v0.0.104). - Update
SelectionHistorydocumentation andtoJsonnote to reference pre-/post-v0.0.101 shapes consistently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/core/models/available_servers.dart | Fixes version references in user_failures doc/toJson comments to match the actual lantern-box tag where the shape changed. |
| test/core/models/available_servers_test.dart | Fixes version references in the user_failures deserialization test preamble comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Follow-up to #8929. Comments only — no behavior change.
The comments I added in #8929 name v0.0.104 as the lantern-box release that changed each
user_failuresentry from a bare RFC3339 string to a{"at", "kind"}object. Wrong: v0.0.104 was just the edge of the module cache I sampled. Verified against the actual tags:TagHistory.UserFailures[]time.Time[]UserFailureThe change is lantern-box #286 (
b2c28bb, 2026-07-09), first tagged v0.0.101.The whole job of these comments is to send a future reader to the version where the shape changed, so an off-by-three defeats their only purpose. #8929's description was corrected before merge; the comments and its commit message weren't. The commit message is immutable now — this fixes the code.
Four occurrences, all in comments:
lib/core/models/available_servers.dart— the_userFailureAtdoc comment, and thetoJsonnote about the pre-change shapetest/core/models/available_servers_test.dart— theuser_failures deserializationgroup preamble (2)🤖 Generated with Claude Code
Summary by CodeRabbit
user_failurestimestamp formats.