fix(web,api): truthful instances everywhere — node names, stacked in Server view, live status, fleet-wide update banner#59
Merged
Conversation
…Server view, live status, fleet-wide update banner F1 — dashboard INSTANCES cards now show the node NAME (Spark-2-DGX), not the raw node-id hex, for single/stacked cards (renderInstances host = node_name), falling back to the id when the name is unknown. F2 — Server view LOADED MODELS now includes stacked instances as rows: the local InstanceManager (ports 8001+) and each peer's announced instances[], each with model, node name, port, READY/STARTING, and Eject only where the local eject endpoint can target it (remote rows render without Eject). The count now reflects total instances, not just per-node primaries. F3 — instance status no longer sticks at 'starting'. _live_instance_records flips each live record's status to 'serving' when its engine answers the localhost /v1/models probe, so the announcement carries the truth and the GUI stops painting a 'STARTING · 8%' bar for an instance that's serving. F4 — the update banner is fleet-wide: the badge confirms 'Update all N nodes to vX? Services restart one by one.' and POSTs /api/cluster/update-all (resolves one target, threads to peers), with a failure toast and the re-check bumped 60s→90s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four operator-reported GUI-truth defects from this morning's live review:
servingwhen the engine answers and (review catch) back tofailedwhen it dies, at the source that feeds both the broadcast and the Server view; the stacked-card status no longer ORs with the primary's readiness (second review catch). 3 regression tests on the both-directions probe./api/cluster/update-allwith an honest confirm ("Update all N nodes… restart one by one"), wires the progress panel, failure toast.670 passed, 1 xfailed; ruff clean; node --check OK. Review-gated (2 majors found and fixed).
🤖 Generated with Claude Code
https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak