fix(models,web): real cancellable downloads (commit-pinned, parallel); launch form respects user node picks#56
Merged
Conversation
…); stop launch auto-recommend clobbering user node picks Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two majors from the final lifecycle verification on the 0.5.1 fleet:
snapshot_download(which has no cancel hook anyway); a cancelled 15 GB download ran to completion. Rebuilt as per-filehf_hub_downloadwith the cancel flag checked between files. Review then caught two regressions in the first cut, both fixed: commit pinning (repo_info resolves the sha once; every file fetch carriesrevision=<sha>— no more mixed-commit snapshots if the repo is pushed mid-download) and parallelism (bounded ThreadPoolExecutor viaAINODE_DOWNLOAD_MAX_WORKERS, cancellable futures). Layout identical to snapshot_download by construction; progress/token/handler contracts unchanged.665 passed, 1 xfailed; ruff clean; node --check OK. New tests: layout-identity + revision-pinning assertion, cancel-between-files, cancel-before-first-file.
🤖 Generated with Claude Code
https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak