Skip to content

Remove room index option for winners #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getBoolean merged 1 commit into from
May 31, 2026
Merged

Remove room index option for winners #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions data/migrations/0014_narrow_wind_dancer.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
DROP INDEX `event_winner_event_id_room_index_user_id_unique`;--> statement-breakpoint
CREATE UNIQUE INDEX `event_winner_event_id_user_id_unique` ON `event_winner` (`event_id`,`user_id`);--> statement-breakpoint
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Deduplicate winners before adding unique index

This migration fails on any existing database where the same user was declared a winner for multiple rooms in the same event, which the previous (event_id, room_index, user_id) unique constraint explicitly allowed. When such rows exist, CREATE UNIQUE INDEX ... (event_id, user_id) raises a uniqueness error before room_index is dropped, so the bot cannot migrate/start for those guilds; add a data-migration step to collapse or delete duplicates before creating the new unique index.

Useful? React with 👍 / 👎.

ALTER TABLE `event_winner` DROP COLUMN `room_index`;
Loading