Repository navigation
Fix TM/HM compatibility with randomized move types - #502
Merged
gerbiljames merged 1 commit intoOct 16, 2026
Merged
gerbiljames merged 1 commit into
gerbiljames merged 1 commit into
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move type randomization updates the generated moves, but HMs, unchanged TMs, and reserved TMs such as Headbutt and Rock Smash can retain their original type in the TM/HM record. Compatibility reads that cached type, which can select the wrong same-type or other-type percentage.
For example, if Surf becomes FIRE, a WATER Pokémon is incorrectly allowed to learn it with same-type compatibility at 100% and other-type compatibility at 0%. A FIRE Pokémon is incorrectly rejected.
Resolve the type from the generated move assigned to each TM/HM instead. Compatibility then follows the move’s effective type while retaining the existing vanilla fallback and HM overrides.
Validated that TM/HM compatibility follows the generated move types across the affected configurations. The full Crystal test suite also passed during validation.