Repository navigation
fix(values): correct Envelope.from_bbox axis order - #174
Closed
C1-BA-B1-F3 wants to merge 1 commit into
Closed
C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
Contributor
Author
|
Merged current |
GeoJSON bbox order is [minx, miny, maxx, maxy], but the old code treated the second half as starting at index len//2, which scrambled longitudes and latitudes. 3D bbox (6 elements) had the same issue. Fixes geopython#163
C1-BA-B1-F3
force-pushed
the
fix/cql2-json-bbox-axis-order
branch
from
October 6, 2026 15:43
0bf2c6a to
13cf609
Compare
C1-BA-B1-F3
changed the title
Contributor
|
This was already fixed with #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoJSON bbox order is
[minx, miny, maxx, maxy], but the oldfrom_bboxtreated the second half as starting at indexlen//2, producing scrambled coordinates. The 3D bbox (6 elements) had the same issue.Fix
Rewrite
Envelope.from_bboxto explicitly unpack(minx, miny, maxx, maxy)from 4-element and(minx, miny, minz, maxx, maxy, maxz)from 6-element bbox arrays.Changes from previous version
values.pywhere it belongs (instead of patching the parser)Fixes #163