Skip to content

Executing tests in Docker is broken #103

Closed

Description

@captaincoordinates

The README's instructions for executing tests in Docker are broken. This is partly because tests/execute-tests.sh was deleted (seemingly without reason) in this commit and partly because the approach has not been maintained in line with new test dependencies.

Personally I would prefer that the GitHub Actions Workflow executed tests using Docker, so that developers can guarantee tests will behave equally in both environments and as an incentive to ensure the Docker approach is maintained, however I appreciate that approach might not be to everyone's taste.

I have a fork that fixes Docker tests and I will submit a PR after creating this issue.

PR #104

Activity

  1. added 2 commits that reference this issue on Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions