Skip SRF sources with slip_sum=0 and fix sfileoutput#240
Open
Skip SRF sources with slip_sum=0 and fix sfileoutput#240
Conversation
There was a problem hiding this comment.
Pull request overview
Updates rupture-source ingestion to detect near-zero slip-velocity integrals (and report them), improves Sfile HDF5 metadata, and removes an HDF5 group flush that can cause platform issues.
Changes:
- Add detection/logging for SRF rupture points with ~zero
dt*sum(slip_vel)and report totals skipped. - Add
"Coarsest horizontal grid spacing"attribute to Sfile HDF5 header output. - Disable
H5Gflush(grp)inTimeSeriesHDF5 writing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/TimeSeries.C |
Comments out H5Gflush(grp) after final write. |
src/SfileOutput.C |
Writes new HDF5 scalar attribute for coarsest horizontal grid spacing. |
src/readhdf5.C |
Adds zero-slip-integral detection, warning prints, and summary counter for HDF5 rupture input. |
src/parseInputFile.C |
Adds equivalent zero-slip-integral detection, warning prints, and summary counter for text SRF rupture input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.