Skip to content

Skip SRF sources with slip_sum=0 and fix sfileoutput#240

Open
houjun wants to merge 5 commits intomasterfrom
fix-sfile-srf
Open

Skip SRF sources with slip_sum=0 and fix sfileoutput#240
houjun wants to merge 5 commits intomasterfrom
fix-sfile-srf

Conversation

@houjun
Copy link
Copy Markdown
Collaborator

@houjun houjun commented Apr 7, 2026

  • Skip SRF sources with slip_sum=0 and print out the skipped messages
  • Write out "Coarsest horizontal grid spacing" for sfile output
  • Removed unnecessary H5Gflush that may cause issues in some systems
  • Fix NumPy int issue in pytest

Copilot AI review requested due to automatic review settings April 7, 2026 23:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates rupture-source ingestion to detect near-zero slip-velocity integrals (and report them), improves Sfile HDF5 metadata, and removes an HDF5 group flush that can cause platform issues.

Changes:

  • Add detection/logging for SRF rupture points with ~zero dt*sum(slip_vel) and report totals skipped.
  • Add "Coarsest horizontal grid spacing" attribute to Sfile HDF5 header output.
  • Disable H5Gflush(grp) in TimeSeries HDF5 writing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/TimeSeries.C Comments out H5Gflush(grp) after final write.
src/SfileOutput.C Writes new HDF5 scalar attribute for coarsest horizontal grid spacing.
src/readhdf5.C Adds zero-slip-integral detection, warning prints, and summary counter for HDF5 rupture input.
src/parseInputFile.C Adds equivalent zero-slip-integral detection, warning prints, and summary counter for text SRF rupture input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants