Skip to content

Add gmsh installation for docs build #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasPluck merged 3 commits into from
Apr 19, 2026
Merged

Add gmsh installation for docs build #148

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
133d042
Add gmsh installation to Makefile for docs build
joamatab Apr 17, 2026
90cfb10
chore: sync workflow secrets + uv.lock from upstream template
ThomasPluck Apr 19, 2026
6141b18
Install OSMesa and EGL for headless pyvista rendering in docs
ThomasPluck Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ build:
pip install build
python -m build

docs-clean:
gmsh:
sudo apt-get update
sudo apt-get install -y python3-gmsh gmsh libglu1-mesa libxi-dev libxmu-dev libglu1-mesa-dev
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Running sudo apt-get inside a make target can break non-root or CI usage.

This target assumes sudo is available and that the system uses apt-get, which will fail or be disallowed in many CI/container/non-root environments and can cause side effects when running make. Please either treat these as documented manual prerequisites, move them to a separate setup script, or gate this target behind an explicit opt-in flag (e.g. ENABLE_SYSTEM_INSTALL=1).


docs-clean: gmsh
rm -rf docs/_build

docs: docs-clean
Expand Down
Loading