Skip to content

fix(office-hours): unify profile paths on developer-profile.json#1790

Open
NikhileshNanduri wants to merge 1 commit into
garrytan:mainfrom
NikhileshNanduri:fix/1677-office-hours-session-count
Open

fix(office-hours): unify profile paths on developer-profile.json#1790
NikhileshNanduri wants to merge 1 commit into
garrytan:mainfrom
NikhileshNanduri:fix/1677-office-hours-session-count

Conversation

@NikhileshNanduri
Copy link
Copy Markdown

Summary

Two call sites in /office-hours still referenced the legacy builder-profile.jsonl path after the v1.0.0.0 migration. That file gets archived on first read, so on fresh-$HOME installs both calls silently produced nothing.

  1. gbrain artifact glob (kind: filesystem, glob) — changed from ~/.gstack/builder-profile.jsonl to ~/.gstack/developer-profile.json; removed tail: 1 (not JSONL).
  2. Phase 6 profile reader — changed from gstack-builder-profile (legacy shim) to gstack-developer-profile --read (direct). Behavior is identical; removes the indirection layer.

The writer side was already fixed in v1.44.1.0 (PR #1682, fix #1671). This PR closes the remaining reader/artifact half.

Closes #1677.

Test plan

  • bun test test/skill-coverage-floor.test.ts passes (315 assertions)
  • bun test full free suite passes

🤖 Generated with Claude Code

…rytan#1677)

The gbrain artifact glob and Phase 6 reader both still pointed to the
legacy builder-profile.jsonl. After migration that file gets archived,
so both calls silently produced nothing on fresh-$HOME installs.

- Artifact glob: builder-profile.jsonl → developer-profile.json
- Phase 6 reader: gstack-builder-profile shim → gstack-developer-profile --read
- Regenerate office-hours/SKILL.md

Writer fix was in v1.44.1.0 (garrytan#1671); this closes the remaining
reader/artifact half.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jbetala7
Copy link
Copy Markdown
Contributor

One stale-premise note from current origin/main (62024d11): bin/gstack-builder-profile is already a legacy shim that executes gstack-developer-profile --read, so the Phase 6 command replacement is not the behavior fix for SESSION_COUNT on current main.

The remaining real behavior change here is the gbrain artifact source: office-hours/SKILL.md.tmpl still points at ~/.gstack/builder-profile.jsonl with tail: 1, while current sessions are written to ~/.gstack/developer-profile.json. I would narrow the PR body/changelog to that artifact-glob fix and add a regression proving the generated office-hours skill reads the developer-profile JSON artifact after gstack-developer-profile --log-session.

Also, GitHub reports this branch DIRTY, and the PR bumps VERSION/package.json to 1.48.3.0 while main is already 1.52.2.0, so the release files need a rebase/drop before this can land cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/office-hours always reports SESSION_COUNT: 0, welcome_back tier is unreachable

2 participants