fix(config): preserve spaces in config values#1783
Open
jbetala7 wants to merge 1 commit into
Open
Conversation
a61a8a3 to
6b3d6e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key:whengstack-config getreads config values, instead of taking only the second whitespace-delimited fieldgstack-config listactive valuesworkspace_rootvalues containing spacesFixes #1782
Root cause
gstack-config getusedawk '{print $2}', which silently truncated values likeworkspace_root: /tmp/Conductor Workspacesto/tmp/Conductor.gstack-next-versionconsumesworkspace_rootfor sibling worktree scanning, so configured roots with spaces were ignored.Tests
bun test test/explain-level-config.test.ts test/docs-config-keys.test.tsbun test test/gstack-next-version.test.ts test/brain-sync.test.ts test/explain-level-config.test.tsbash -n bin/gstack-configgit diff --checkgstack-config set workspace_root "/tmp/Conductor Workspaces"thenget workspace_rootreturns the full pathCollision checks
Searched open and closed issues/PRs for
workspace_root space,gstack-config config.yaml space, and open PRs touchinggstack-config. No existing issue or canonical PR covered this truncation bug.