[codex] Fix ship qa-only path for Codex host#1772
Open
spacegeologist wants to merge 1 commit into
Open
Conversation
ad35e65 to
67af98f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the generated Codex-host
/shipskill so plan verification loads/qa-onlyfrom the Codex gstack skill layout.Related context
This is part of the same Codex-host compatibility cleanup series as the earlier Codex adaptation PR. The prior PR handled Codex-specific auth/preflight behavior; this PR addresses a separate generated-skill path issue in
/shipplan verification.Root cause
/shipplan verification was still emitting the Claude-specific${CLAUDE_SKILL_DIR}/../qa-only/SKILL.mdlookup. In Codex installs, generated skills are prefixed siblings likegstack-qa-only, and the runtime preamble exposes$GSTACK_ROOT, so the Claude-only path cannot resolve.What changed
${CLAUDE_SKILL_DIR}/../qa-only/SKILL.md.gstack-ship.CI note
The earlier draft head touched
scripts/resolvers/review.ts, which caused review/design eval shards to run on a fork PR without API secrets and fail witherror_api. The current head avoids that shared resolver touch; the rerun shows all E2E/LLM eval jobs passing, including the previously failinge2e-designande2e-reviewshards.The only remaining red job is
report, which fails while posting the PR comment withGraphQL: Resource not accessible by integration (addComment). That is the known fork PR comment-permission limitation rather than a test failure.Validation
bun test test/gen-skill-docs.test.ts— 390 passbun test test/codex-hardening.test.ts— 29 passbun run gen:skill-docs --host codex --dry-run— all Codex skills FRESHbun run eval:select --base origin/main— E2E 0/165, LLM-judge 0/28 affected67af98f: Skill Docs Freshness, Workflow Lint, Windows Free Tests, and all E2E/LLM eval shards passgit diff --check