cherry-pick improvements from #1635#1
Conversation
| if: steps.prepare-meta.outputs.has-image | ||
| timeout-minutes: 120 | ||
| run: cargo xtask build-docker-image -v "${TARGET}${SUB:+.$SUB}" ${{ matrix.verbose && '-v' || '' }} --platform ${{ matrix.platform }} | ||
| run: cargo xtask build-docker-image -v "${TARGET}${SUB:+.$SUB}" ${{ matrix.verbose && '-v' || '' }}${{ matrix.platform && '--platform ' }}${{ join(matrix.platform) || '' }} |
There was a problem hiding this comment.
This change seems not necessary
There was a problem hiding this comment.
It's a very neat trick, if platforms are configured they will be used, otherwise it will be empty.
garasubo
left a comment
garasubo
left a comment
There was a problem hiding this comment.
Your second commit looks good, but I couldn't understand the purpose of the first commit. Could you explain it?
|
Don't kill the messenger, I just cherry-picked all improvements from #1635 for you 😅 |
|
@reneleonhardt I meant why do you cherry-pick that commit? If there are no special reason, I'll close it. |
You can close any contribution if you want, it's your fork. Emilgardis tried to improve your PR:
You said it's not possible to merge those improvements into your PR:
So I merged those changes in for you. |
3 participants
Contents