HUMAnN update#3657
Conversation
|
I forgot that the PR of the conda package is still not merged: bioconda/bioconda-recipes#28066 |
bernt-matthias
left a comment
There was a problem hiding this comment.
Looks pretty good. Left a few comments. Not sure about tsv vs. tabular .. I think tabular is preferred.
Is tools/humann/generate_test_data still used to generate the test data? Would be great. Otherwise it should be removed.
I was not sure neither. I will change all to Tabular |
I remove it |
|
I do not understand why the last test for the DM is failing. It seems that the file or directory in which data need to be moved is not found but why? |
|
Thanks a lot @bernt-matthias |
FOR CONTRIBUTOR:
This PR:
.xmlto broken tools in current conda package (open PR on upstream tool)@bernt-matthias I would love to have your feedback on this PR (if you have the time)
I renamed the folder from
humann2tohummann, similarly to what the tool developers did (now on GitHub).It may help with further version updates, but it may break the current lineage.
Let me know if I should change that.