DCA sell function#342
Open
Divljo31 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 87580ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Divljo31
temporarily deployed
to
upgrade-ui-master
July 17, 2026 08:52 — with
GitHub Actions
Inactive
|
🧚 Live preview: galacticcouncil/hydration-ui#3968 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large sell-intent TWAP orders stall with
DCA.TradeLimitReached: theper-trade
min_amount_outfloor is frozen at setup, then the order's ownprice impact breaches it and every slice fails until the schedule
terminates.
This adds a
DcaSellorder type that builds the sell as a DCASellwithmin_amount_out = 0— the same shape the DCA product has shipped for years.Per-trade protection then comes from the pallet's adaptive oracle slippage
limit (recomputed each block from the schedule's
slippage), which tracksthe market instead of a stale floor.