Use registry asset id for metadata lookups in xcm transfer#3969
Open
hitchho wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for hydration-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for testnet-hydra-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for edge-hydra-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jvonasek
self-requested a review
July 20, 2026 11:15
jvonasek
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xcm transfer module resolves registry metadata (logos, prices, symbol/name) through
registryChain.getBalanceAssetId(). That returns the balance-query id, which diverges from the registry id for any asset that defines abalanceId— e.g. erc20-backed assets whose balances are read from a contract address. The registry lookup then receives a0x…address instead of the asset id and misses, rendering a "?" logo and no price.Switches the five call sites to
registryChain.getAssetId(), which is the chain-internal registry id these lookups actually want.Surfaced while testing the HOLLAR ↔ AssetHub routes (galacticcouncil/sdk#343): HOLLAR carries
balanceId: 0x531a…(GHO contract) for balance reads, and every metadata lookup in the transfer form broke. With this change the HOLLAR icon and spot price resolve correctly from asset 222. No behavior change for existing assets — on the hydration registry chain,getAssetIdandgetBalanceAssetIdare identical whereverbalanceIdis unset.