Conversation
BREAKING CHANGE: SPM consumers need Xcode 15 / Swift 5.9 or later. Deployment targets are unchanged (macOS 10.13, iOS 12, tvOS 12, watchOS 4, visionOS 1) but are now explicit in the manifest instead of relying on SPM defaults.
Runs swift test on the official swift:6.2 container; the only Foundation dependency is CharacterSet.urlHostAllowed, available in swift-corelibs-foundation. Added to the CI Success gate.
Completes the gumob -> futamura account rename; the tools-version requirement bump makes this a major release.
CocoaPods is sunsetting (trunk read-only 2026-12-02); the install section keeps its migration warning.
decodePunycode returned garbage for malformed input and could trap on adversarial input: - inputs ending mid-digit-sequence now return nil (RFC 3492 bad input) - decoded C1 control scalars (U+0080...U+009F) now return nil - the overflow checks required by RFC 3492 sections 6.3/6.4 are implemented with checked arithmetic; overflowing inputs return nil instead of crashing encodeIDNA now maps the hostname first (NFKC folding, lowercasing, NFC, ideographic full stop to '.'), so full-width forms and alternate dots encode correctly; the full UTS #46 table is intentionally out of scope. decodedIDNA accepts an uppercase ACE prefix (RFC 5890). punycodeEncoded stays raw RFC 3492 and is now documented as such, with idnaEncoded pointed to for hostnames. The UnicodeScalar.isValid helper checked surrogate bounds that Unicode.Scalar cannot represent (and had a typo, 0xD880); it now excludes C1 controls, shared by encode and decode. Closes #78 Closes #4
Applying idnaEncoded to a full URL mangles it: the scheme and path get
swallowed into labels ("http://www" becomes one label). The new
variants locate the host of [scheme://][userinfo@]host[:port][/rest]
by hand (no new dependencies) and transform only that segment. IPv6
literals pass through; a "://" inside a query is not mistaken for a
scheme delimiter.
Motivated by futamura/TLDExtractSwift#8, whose README example applied
idnaEncoded to a URL.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| name: "PunycodeSwiftTests", | ||
| dependencies: ["Punycode"], | ||
| path: "Tests") | ||
| path: "Tests"), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| .iOS(.v12), | ||
| .tvOS(.v12), | ||
| .watchOS(.v4), | ||
| .visionOS(.v1), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| name: "PunycodeSwiftTests", | ||
| dependencies: ["Punycode"], | ||
| path: "Tests") | ||
| path: "Tests"), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| .iOS(.v12), | ||
| .tvOS(.v12), | ||
| .watchOS(.v4), | ||
| .visionOS(.v1), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 97.57% 98.73% +1.15%
==========================================
Files 3 3
Lines 165 237 +72
==========================================
+ Hits 161 234 +73
+ Misses 4 3 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The repeat-while with a break confused coverage region mapping (lines after the break reported as unexecuted); the equivalent while-with-flag form maps cleanly and drops the separate post-loop completeness guard. Remaining uncovered lines are the practically unreachable overflow guards required by RFC 3492.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Everything staged for the 4.0.0 release:
Package.swiftrequires swift-tools 5.9 (Xcode 15+ for SPM consumers) and declares explicit platforms (deployment targets unchanged: macOS 10.13, iOS 12, tvOS 12, watchOS 4, visionOS 1).SPM: Linux, Swift 6.2CI job on the official Swift container, part of the CI Success gate.idnaEncodedmaps input first (NFKC folding, lowercasing, NFC, ideographic full stop);idnaDecodedaccepts uppercase ACE prefixes;punycodeEncodeddocumented as the raw RFC 3492 single-label transform.idnaEncodedURL/idnaDecodedURLtransform only the host of a URL-shaped string (motivated by Example with idna-encoded string does not work TLDExtractSwift#8).dev.futamura.*; version bumped to 4.0.0; CocoaPods badges dropped from the README.Merging closes #78 and #4.
Release plan
After merge: push the
4.0.0tag —release.ymlverifies it againstMARKETING_VERSION, creates the GitHub Release from the changelog section, and pushes to CocoaPods trunk.Test plan