-
-
Notifications
You must be signed in to change notification settings - Fork 1
mainfish #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frenchfish
wants to merge
4
commits into
furesoft:main
Choose a base branch
from
frenchfish:mainfish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
mainfish #9
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| using System; | ||
| using System.Collections.Concurrent; | ||
| using System.Collections.Generic; | ||
| using System.Globalization; | ||
| using Avalonia.Data.Converters; | ||
| using Avalonia.Media; | ||
| using Avalonia.Media.Imaging; | ||
| using Avalonia.Platform; | ||
| using RomManager.Core.RegionDetection; | ||
|
|
||
| namespace RomManager.Converters; | ||
|
|
||
| public sealed class FavouriteToImageConverter : IValueConverter | ||
| { | ||
| private static readonly ConcurrentDictionary<bool, IImage?> IconCache = new(); | ||
| private static readonly Dictionary<bool, string> FavouriteToIcon = new() | ||
| { | ||
| { true, "favourite" }, | ||
| { false, "unfavourite" }, | ||
|
|
||
| }; | ||
| /* Uri uri; | ||
| if (IsFavourite == true) | ||
| { | ||
| uri = new Uri("avares://RomManager/Assets/Icons/Games/favourite.png"); | ||
| } | ||
| else | ||
| { | ||
| uri = new Uri("avares://RomManager/Assets/Icons/Games/unfavourite.png"); | ||
| } | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could use something like this: var iconName = IsFavourite ? "favourite" : "unfavourite";
var uri = new Uri($"avares://RomManager/Assets/Icons/Games/{iconName}.png"); |
||
| using var stream = AssetLoader.Open(uri); | ||
| FavouritePAth = new Bitmap(stream);*/ | ||
|
|
||
|
|
||
|
|
||
|
|
||
| public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture) | ||
| { | ||
| if (value is not bool icon) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| return IconCache.GetOrAdd(icon, static icon => | ||
| { | ||
| var iconName = FavouriteToIcon[icon]; | ||
| var uri = new Uri($"avares://RomManager/Assets/Icons/Games/{iconName}.png"); | ||
|
|
||
| if (!AssetLoader.Exists(uri)) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| using var stream = AssetLoader.Open(uri); | ||
| return new Bitmap(stream); | ||
| }); | ||
| } | ||
|
|
||
| public object? ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture) | ||
| { | ||
| throw new NotSupportedException(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,7 +73,9 @@ private Game GetGame(PathsConfiguration pathsConfiguration, string file) | |
| GameInfo gameInfo; | ||
| if (!GameList.GamesByFilename.TryGetValue(System.IO.Path.GetFileName(file), out gameInfo)) | ||
| { | ||
| gameInfo = new GameInfo { Path = file, Name = System.IO.Path.GetFileNameWithoutExtension(file) }; | ||
| //DELETE TEST | ||
| gameInfo = new GameInfo { Path = file, Name = System.IO.Path.GetFileNameWithoutExtension(file),IsFavorite = false}; | ||
| // gameInfo = new GameInfo { Path = file, Name = System.IO.Path.GetFileNameWithoutExtension(file) }; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. delete the test code |
||
| } | ||
|
|
||
| return new Game | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.