Wrap potential error in the _cat_file_concurrent #1035
Conversation
|
Am I understanding, that in your situation the initial _call_s3 succeeds, but then the subsequent real stalls? I would not have thought that was retriable - are you finding (via logging) that you do sometimes succeed on second/third calls? |
|
Perhaps this could be tested via a mock on the read method, to produce a timeout ont he first call. |
|
Yes, something like that. it happens only on a large workload to 5-10 out of 60 jobs. We had different issues and we inserted custom error handler for reties of timeouts, but it did not catch that. After that change the problem disappears. I haven't run the fix with a debug log level yet because the logs are GBs in size, but I will and let you know :) Ending of the trace: |
|
Extensive tests showed that the error in that place is only sometimes recoverable (and other times retry gives same error again and again). Due to this I am currently pivoting to retry on a higher level that will be more reliable than this solution. |
I'm using
zarrwith s3 ands3fsstore backend. I have a encountered problems with_cat_file_concurrentmethod, with large load it can throw anAioTimeoutErrornot respecting s3fs retries. Adding a missing_error_wrapperin the place of failure.