Async API for Process#2880
Open
Thorium wants to merge 1 commit intofsprojects:masterfrom
Open
Conversation
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit ab46d9e. ♻️ This comment has been updated with latest results. |
xperiandri
approved these changes
Oct 28, 2025
dea7aec to
ab46d9e
Compare
Contributor
|
Looks like it needs fantomas running on the changes? |
This was referenced Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAKE is used by many .NET ecosystems via not only .NET application or exe-file, but also via libraries.
Thus in some cases it would be more beneficial to expose more the Async API instead of FAKE do Async.RunSynchronously everywhere (which is OK in console application), because big enterprise build scripts could maybe benefit of this asynchrony.
So this PR is a start, to expose Process.fs methods also by Async. But for backward compatibility the old methods should also be kept.