Skip to content

Some maintenance updates to help upcoming .NET 8 migration#2826

Merged
xperiandri merged 2 commits intofsprojects:masterfrom
Thorium:net6-updates
Sep 23, 2024
Merged

Some maintenance updates to help upcoming .NET 8 migration#2826
xperiandri merged 2 commits intofsprojects:masterfrom
Thorium:net6-updates

Conversation

@Thorium
Copy link
Copy Markdown
Member

@Thorium Thorium commented Sep 20, 2024

Updated expired runtime-identifiers to current version:
https://learn.microsoft.com/en-us/dotnet/core/rid-catalog#known-rids

Added few explicit types to places where .NET8 will have multiple overloads so compiler won't be able to pick correct types.

Addressed the issue detecting .NET-assemblies in the future, pointed out here: #2818 (comment)

@Thorium Thorium changed the title Some maintenance updates to help .NET 8 migration Some maintenance updates to help upcoming .NET 8 migration Sep 20, 2024
@Thorium
Copy link
Copy Markdown
Member Author

Thorium commented Sep 21, 2024

Looking the build-logs, it was naive to expect only reference-assemblies have GitHub account under dotnet, because e.g. System.Text.Json can come either from .NET reference assembly or Nuget, and they both have same repository url. I'll try to invent something better.

Edit: Further investigation: It might be ok, because it's just a back-up solution.

@xperiandri
Copy link
Copy Markdown
Collaborator

Could you rebase on top of the latest master?

Comment thread build.fsx
Comment thread src/app/Fake.Runtime/CoreCache.fs
@Thorium
Copy link
Copy Markdown
Member Author

Thorium commented Sep 22, 2024

Rebased passing build, now failed for ".NET Core SDK install failed with code", maybe a network error.

@xperiandri xperiandri merged commit 4d0bf7d into fsprojects:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants