Receive new lexicon types#281
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
tom-sherman
force-pushed
the
handle-receive-new-lexicon-types
branch
from
4b2249c to
fe71208
Compare
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
tom-sherman
force-pushed
the
handle-receive-new-lexicon-types
branch
from
deaeb10 to
ddb9d5c
Compare
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
tom-sherman
force-pushed
the
handle-receive-new-lexicon-types
branch
from
13ba8bd to
5de56f7
Compare
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
tom-sherman
commented
Nov 18, 2025
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
Contributor
WillCorrigan
left a comment
WillCorrigan
left a comment
There was a problem hiding this comment.
Just 2 small things
| }; | ||
| } else if (collection === nsids.FyiFrontpageFeedPost) { | ||
| const record = await atproto.fyi.frontpage.feed.post.get({ repo, rkey }); | ||
| const subject = record.value.subject; |
Contributor
There was a problem hiding this comment.
What is subject and how come we don't check it on old unravel ones? New for frontpage schema?
Contributor
Author
There was a problem hiding this comment.
Yeah have a read through #232 for context. Current types don't have a subject, just a url field.
tom-sherman
commented
Nov 21, 2025
WillCorrigan
approved these changes
Nov 21, 2025
vercel
Bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #284 and #285
I don't wanna start creating these types yet. The intention of this PR is to just receive the new types for anyone else creating them outside of our app, our app and API should continue to create the old types for now.