Skip to content

fix: respect tsconfig exclude patterns in project ownership checks #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EladBezalel merged 3 commits into from
Mar 23, 2026
Merged

fix: respect tsconfig exclude patterns in project ownership checks #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84aff04
fix: respect tsconfig exclude patterns in project ownership checks
EladBezalel Mar 22, 2026
9815edd
fix(ci): sync yarn.lock with package.json after 1.0.1 release
EladBezalel Mar 22, 2026
acea9d1
docs: clarify why resolve_extends skips bare package specifiers
EladBezalel Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,10 @@ jobs:
run: |
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
git add package.json Cargo.toml
# generate-packages.js bumps optionalDependencies to the new version — refresh lockfile
# so CI (yarn install --frozen-lockfile) does not fail on the version commit.
yarn install
git add package.json Cargo.toml yarn.lock
git commit -m "${{ steps.bump.outputs.new_version }}"
git tag "v${{ steps.bump.outputs.new_version }}"
git push --atomic origin main "v${{ steps.bump.outputs.new_version }}"
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,19 @@
"typescript": "^5.9.2"
},
"optionalDependencies": {
"@front-ops/domino-darwin-arm64": "1.0.1",
"@front-ops/domino-darwin-x64": "1.0.1",
"@front-ops/domino-linux-arm64-gnu": "1.0.1",
"@front-ops/domino-linux-arm64-musl": "1.0.1",
"@front-ops/domino-linux-x64-gnu": "1.0.1",
"@front-ops/domino-linux-x64-musl": "1.0.1",
"@front-ops/domino-win32-x64-msvc": "1.0.1",
"@oxc-node/core-darwin-arm64": "^0.0.34",
"@oxc-node/core-darwin-x64": "^0.0.34",
"@oxc-node/core-linux-arm64-gnu": "^0.0.34",
"@oxc-node/core-linux-arm64-musl": "^0.0.35",
"@oxc-node/core-linux-x64-gnu": "^0.0.34",
"@oxc-node/core-linux-x64-musl": "^0.0.35",
"@front-ops/domino-darwin-x64": "1.0.1",
"@front-ops/domino-darwin-arm64": "1.0.1",
"@front-ops/domino-win32-x64-msvc": "1.0.1",
"@front-ops/domino-linux-x64-gnu": "1.0.1",
"@front-ops/domino-linux-x64-musl": "1.0.1",
"@front-ops/domino-linux-arm64-musl": "1.0.1",
"@front-ops/domino-linux-arm64-gnu": "1.0.1"
"@oxc-node/core-linux-x64-musl": "^0.0.35"
},
"lint-staged": {
"*.@(js|ts|tsx)": [
Expand Down
4 changes: 3 additions & 1 deletion src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ fn find_affected_internal(
}

// Step 2: Build project index for O(unique_roots) lookups instead of O(n_projects)
let project_index = ProjectIndex::new(&config.projects);
// Also parses each project's tsconfig to extract exclude patterns, so that
// files excluded by tsconfig (e.g. stories, specs) don't mark a project affected.
let project_index = ProjectIndex::new(&config.projects, &config.cwd);

// Step 3: Build workspace analyzer (includes building import index)
debug!("Building workspace semantic analysis...");
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ pub mod lockfile;
pub mod profiler;
pub mod report;
pub mod semantic;
pub mod tsconfig;
pub mod types;
pub mod utils;
pub mod workspace;
Expand Down
1 change: 1 addition & 0 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ mod lockfile;
mod profiler;
mod report;
mod semantic;
mod tsconfig;
mod types;
mod utils;
mod workspace;
Expand Down
Loading
Loading