feat: add include pattern matching for test file detection by EladBezalel · Pull Request #22 · frontops-dev/domino

EladBezalel · 2026-02-08T13:11:44Z

Summary

Implement traf's changedIncludedFilesPackages mechanism so that changed files matching configurable regex patterns directly mark their owning project as affected
Default pattern matches test/spec files: \.(spec|test)\.(ts|js)x?$
When include is empty (default), the default test file pattern is applied automatically
Custom patterns can be passed via the N-API include option or CLI config

Root Cause

Traf has a changedIncludedFilesPackages step that runs on ALL changed files before semantic analysis. Any file matching an include pattern (default: test/spec files) immediately adds its owning project to the affected set. Domino had the include field in TrueAffectedConfig but it was marked #[allow(dead_code)] and never used.

This caused domino to miss projects where only test files changed, since test files may not be in the TypeScript project's tsconfig.json and thus invisible to semantic analysis.

Test plan

Unit test for default include pattern matching (.spec.ts, .test.tsx, etc.) and non-matching files
Integration test: .spec.ts file change marks owning project as affected (default pattern)
Integration test: .stories.ts file change with custom include pattern
cargo clippy clean
cargo fmt clean
31 unit tests pass, 2 new integration tests pass

Made with Cursor

github-actions · 2026-02-08T13:18:53Z

📦 Preview Release Available

A preview release has been published for commit acd8ab4.

Installation

npm install https://github.com/frontops-dev/domino/releases/download/pr-22-acd8ab4/front-ops-domino-0.3.7.tgz

Running the preview

npx https://github.com/frontops-dev/domino/releases/download/pr-22-acd8ab4/front-ops-domino-0.3.7.tgz affected

Details

Release: pr-22-acd8ab4
Direct URL: https://github.com/frontops-dev/domino/releases/download/pr-22-acd8ab4/front-ops-domino-0.3.7.tgz

Implement traf's `changedIncludedFilesPackages` mechanism in domino. Changed files matching configurable regex patterns now directly mark their owning project as affected, regardless of whether the file is parsed by the semantic analyzer. Default pattern matches test/spec files: `\.(spec|test)\.(ts|js)x?$` This ensures that when only test files change for a project, the project is still correctly detected as affected -- matching traf's behavior. Co-authored-by: Cursor <[email protected]>

- Include pattern matching now skips files matching ignored_paths - Passing a single empty string in include disables default patterns - Documented opt-out mechanism in TrueAffectedConfig Co-authored-by: Cursor <[email protected]>

shaharkazaz

Good feature — this closes an important parity gap with traf. The core logic is sound and tests cover the main paths well.

Key items to address before merge:

Add AffectCause tracking for include-pattern matches — most important. Without this, --report mode silently omits the reason a project was marked affected.
Reconsider the empty-string sentinel for disabling defaults — Option<Vec<String>> would be safer and more idiomatic.
Rebase onto current main — PR currently has merge conflicts.

Nice-to-haves:

Clarify is_ignored_path scope (only includes? or also source/asset files?)
Cache the default regex pattern
Add edge-case tests (disable sentinel, invalid regex, no owning project)
Fix step numbering

shaharkazaz · 2026-03-04T13:54:07Z

+  // matching traf's changedIncludedFilesPackages behavior.
+  let include_patterns = if config.include.is_empty() {
+    vec![DEFAULT_INCLUDE_PATTERN.to_string()]


Fragile "disable default" API

Using a single empty string as a sentinel to disable defaults is error-prone and non-obvious. A caller passing vec![""] by accident (e.g., splitting an empty CLI arg) would silently disable test file detection.

Consider using Option<Vec<String>> instead:

None → use defaults (test file patterns)

Some(vec![]) → explicitly disable all include patterns

Some(vec!["pattern"]) → custom patterns

This makes the intent explicit at the type level and avoids accidental opt-out.

shaharkazaz · 2026-03-04T13:54:10Z

 use tracing::debug;

+/// Default include pattern: matches test/spec files (.spec.ts, .test.tsx, etc.)
+const DEFAULT_INCLUDE_PATTERN: &str = r"\.(spec|test)\.(ts|js)x?$";
+
+fn is_ignored_path(file_path: &Path, ignored_paths: &[String]) -> bool {
+  if ignored_paths.is_empty() {
+    return false;
+  }
+
+  let file_str = file_path.to_string_lossy();
+  ignored_paths
+    .iter()


is_ignored_path only used for include patterns

This helper is introduced here but ignored_paths is still #[allow(dead_code)] on the TrueAffectedConfig struct. This creates an inconsistency — are ignored paths now active or not?

Should this also be applied to source/asset file processing in Steps 5/5a for full parity with traf? If scoping to include-pattern matching only is intentional, it'd be worth adding a comment explaining why.

shaharkazaz · 2026-03-04T13:54:14Z

+    .collect();
+
+  for changed_file in &changed_files {
+    if is_ignored_path(&changed_file.file_path, &config.ignored_paths) {
+      continue;
+    }
+    let file_str = changed_file.file_path.to_string_lossy();
+    if compiled_patterns.iter().any(|re| re.is_match(&file_str)) {
+      if let Some(pkg) = utils::get_package_name_by_path(&changed_file.file_path, &config.projects)
+      {
+        debug!(
+          "Include pattern matched {:?}, adding package '{}'",
+          changed_file.file_path, pkg
+        );
+        affected_packages.insert(pkg);


No AffectCause recorded for include-pattern matches

When a test file matches an include pattern, the project is added to affected_packages but no AffectCause entry is pushed to project_causes. This means --report mode won't explain why a project was marked affected via include patterns.

Consider either:

Adding a new AffectCause::IncludePatternMatch { file, pattern } variant, or

At minimum, recording a DirectChange with the matched file

This is important for the observability contract — users running domino affected --report will see the project listed with no explanation for why it's affected.

shaharkazaz · 2026-03-04T13:54:16Z

@@ -69,6 +85,45 @@ fn find_affected_internal(
  let mut affected_packages = FxHashSet::default();
  let mut project_causes: FxHashMap<String, Vec<AffectCause>> = FxHashMap::default();


Minor: Step numbering is misleading

This is labeled "Step 4b" but there is no "Step 4a" — the preceding block is "Step 4: Track affected packages". Consider renumbering to make the flow clearer (e.g., make this its own step and renumber downstream).

shaharkazaz · 2026-03-04T13:54:19Z

+    config.include.clone()
+  };
+
+  let compiled_patterns: Vec<Regex> = include_patterns
+    .iter()
+    .filter_map(|p| match Regex::new(p) {
+      Ok(re) => Some(re),
+      Err(e) => {
+        debug!("Invalid include pattern '{}': {}", p, e);
+        None


Minor perf: Regex compiled on every call

Regex::new(DEFAULT_INCLUDE_PATTERN) is called every time find_affected_internal runs. Since domino's selling point is performance, consider using std::sync::LazyLock (Rust 1.80+) or lazy_static! to compile the default pattern once.

Not a blocker, but worth considering.

shaharkazaz · 2026-03-04T13:54:23Z

    "proj2 should be affected via asset → constant → export chain"
  );
 }
+


Missing edge-case tests

Good coverage for the happy paths! A few edge cases worth adding:

include: vec!["".to_string()] — the "disable defaults" sentinel actually disables detection

An invalid regex pattern in include — verify it's gracefully skipped (not a panic)

A matching file that has no owning project — verify it doesn't crash

shaharkazaz · 2026-03-04T13:54:25Z

@@ -1 +1 @@
-Subproject commit 0d6eb7a3c5c9e4e0e19ec9a0cd80e017c55a9c59
+Subproject commit 10ec84a6d723c01d9fbca21e983373b552ef5bd6


Submodule pointer changed — what was added to the fixture monorepo? Please confirm this only contains test fixture changes needed for this PR and not unrelated modifications.

EladBezalel and others added 2 commits February 9, 2026 10:09

EladBezalel force-pushed the fix/include-pattern-matching branch from 16b5f91 to acd8ab4 Compare February 9, 2026 08:09

shaharkazaz requested changes Mar 4, 2026

View reviewed changes

EladBezalel mentioned this pull request Mar 22, 2026

fix: respect tsconfig exclude patterns in project ownership checks #46

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add include pattern matching for test file detection#22

feat: add include pattern matching for test file detection#22
EladBezalel wants to merge 2 commits intomainfrom
fix/include-pattern-matching

EladBezalel commented Feb 8, 2026

Uh oh!

github-actions Bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

shaharkazaz left a comment

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

shaharkazaz Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -69,6 +85,45 @@ fn find_affected_internal(
		let mut affected_packages = FxHashSet::default();
		let mut project_causes: FxHashMap<String, Vec<AffectCause>> = FxHashMap::default();

		@@ -1 +1 @@
		Subproject commit 0d6eb7a3c5c9e4e0e19ec9a0cd80e017c55a9c59
		Subproject commit 10ec84a6d723c01d9fbca21e983373b552ef5bd6

Conversation

EladBezalel commented Feb 8, 2026

Summary

Root Cause

Test plan

Uh oh!

github-actions Bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Preview Release Available

Installation

Running the preview

Details

Uh oh!

shaharkazaz left a comment

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

shaharkazaz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Feb 8, 2026 •

edited

Loading