Skip to content

domains: rename Dillingen SSID and Name#830

Merged
T0biii merged 1 commit intogluon-v2025.1.xfrom
rename-ssid-dlg
Apr 10, 2026
Merged

domains: rename Dillingen SSID and Name#830
T0biii merged 1 commit intogluon-v2025.1.xfrom
rename-ssid-dlg

Conversation

@T0biii
Copy link
Copy Markdown
Member

@T0biii T0biii commented Apr 10, 2026

@T0biii T0biii added gluon-v2025.1.x backport gluon-v2023.1.x Backport to Gluon v2023.1.x Branch backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch labels Apr 10, 2026
@T0biii T0biii marked this pull request as ready for review April 10, 2026 16:29
@T0biii T0biii requested review from a team and maurerle as code owners April 10, 2026 16:29
Copy link
Copy Markdown
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you please make 1 commit out of those 7?

@T0biii
Copy link
Copy Markdown
Member Author

T0biii commented Apr 10, 2026

Looks good, but can you please make 1 commit out of those 7?

yes my idea was to squash on merge but can also squash bevor merge

@grische
Copy link
Copy Markdown
Contributor

grische commented Apr 10, 2026

If you squash them on merge it is not possible to have a merge commit. I'd rather you squash them first.

Revert "fixup! site: rename SSID and Name"

This reverts commit ff5f41f.
@T0biii T0biii enabled auto-merge April 10, 2026 18:08
@T0biii T0biii merged commit e48e7bd into gluon-v2025.1.x Apr 10, 2026
37 checks passed
@T0biii T0biii deleted the rename-ssid-dlg branch April 10, 2026 19:09
@ffmuc-bot
Copy link
Copy Markdown
Contributor

ffmuc-bot Bot commented Apr 10, 2026

Request failed due to following response errors:

  • Pull request Pull request is a draft

@ffmuc-bot
Copy link
Copy Markdown
Contributor

ffmuc-bot Bot commented Apr 10, 2026

Request failed due to following response errors:

  • Pull request Pull request is a draft

@grische grische changed the title site: rename SSID and Name site: rename Dillingen SSID and Name Apr 10, 2026
@grische grische changed the title site: rename Dillingen SSID and Name domains: rename Dillingen SSID and Name Apr 10, 2026
@T0biii T0biii added backport gluon-v2023.1.x Backport to Gluon v2023.1.x Branch and removed backport gluon-v2023.1.x Backport to Gluon v2023.1.x Branch labels Apr 13, 2026
@ffmuc-bot
Copy link
Copy Markdown
Contributor

ffmuc-bot Bot commented Apr 13, 2026

Successfully created backport PR for gluon-v2023.1.x:

@T0biii T0biii added backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch and removed backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch labels Apr 13, 2026
@ffmuc-bot
Copy link
Copy Markdown
Contributor

ffmuc-bot Bot commented Apr 13, 2026

Successfully created backport PR for gluon-v2023.2.x:

@T0biii
Copy link
Copy Markdown
Member Author

T0biii commented Apr 13, 2026

Request failed due to following response errors:

  • Pull request Pull request is a draft

eeeh.. that sould be a different message i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport gluon-v2023.1.x Backport to Gluon v2023.1.x Branch backport gluon-v2023.2.x Backport to Gluon v2023.2.x Branch gluon-v2025.1.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants