For Reference and cherry-picking: Shellcheck fixes#328
Draft
Conversation
Closed
akira25
force-pushed
the
shellcheck_fixes
branch
from
f20efeb to
14b90bd
Compare
Collaborator
|
Is this PR still needed? |
Member
|
In my opinion it is too much to fix all ShellCheck issues in a single PR. It's almost impossible to review. I just added another PR (#356) to introduce ShellCheck with exceptions for files with issues. I would prefer to merge that one and split this PR into smaller chunks that could be reviewed easier and that remove the corresponding exceptions in the same PR. |
Member
Author
|
sounds good to me. In that way, we can get the packages, that are finished already faster into the main branch. |
akira25
changed the title
akira25
force-pushed
the
shellcheck_fixes
branch
from
8dd3056 to
ce886b1
Compare
Merged
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
adjust dependencies, to include jshn too. Signed-off-by: Martin Hübner <martin.hubner@web.de>
noteworthy: removed backtick-notation for subshell calls. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Signed-off-by: Martin Hübner <martin.hubner@web.de>
akira25
force-pushed
the
shellcheck_fixes
branch
from
ce886b1 to
d79576e
Compare
Member
Author
|
Just for letting you know whats going on here: For the commits, that are still valid, I cherry-pick them into other PRs one by one, adjusting them to the current state too. |
Member
Author
|
Afterwards I drop them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes stuff for #315