fix(config): allow unsetting int/float config keys

[Sanjays2402]

Closes #1052

secator config unset <int-key> (e.g. runners.progress_update_frequency) raised TypeError: int() argument must be ... not 'NoneType'. Config.unset() calls set(key, None), but the type-coercion branch ran int(None) before the set_partial handler could interpret None as "reset to default". Coercion is now skipped when the value is None, so the existing reset path runs — same for float/Path keys.

New test_unset_numeric_key fails with that exact TypeError without the one-line source change and passes with it.

Summary by CodeRabbit

• Bug Fixes

  • Fixed configuration handling when removing numeric settings.
  • Unset numeric values are now removed cleanly without conversion errors.
  • Default values are restored when removed settings are loaded again.

• Tests

  • Added coverage for saving, unsetting, and reloading numeric configuration values.

[coderabbitai]

Walkthrough

Config.set() now avoids coercing None, allowing numeric configuration keys to be unset. A unit test verifies YAML removal and restoration of the default value after re-parsing.

Changes

Configuration unsetting

Layer / File(s)	Summary
Skip coercion when unsetting numeric keys secator/config.py, tests/unit/test_config.py	Config.set() bypasses type conversion for None; the test verifies numeric YAML persistence, key removal, and restoration of the default value.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: ocervell

Poem

A rabbit found a number key,
And cleared it cleanly, hop hooray!
No integer spell was cast on None,
The YAML shed its value then,
Defaults returned at break of day.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing config unset for numeric keys.
Linked Issues check	✅ Passed	The fix addresses issue #1052 by skipping coercion on None and adding a test for unsetting a numeric config key.
Out of Scope Changes check	✅ Passed	The changes stay focused on config unsetting behavior and the related regression test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/unit/test_config.py (1)

87-98: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover the float and Path reset paths too.

The PR objective includes integer, float, and Path keys, but this test only exercises an integer. Add equivalent cases for a float and a Path field so the shared None bypass is protected across all affected coercion branches.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/test_config.py` around lines 87 - 98, Extend
test_unset_numeric_key to also unset and verify a float field and a Path field,
covering their set, save, unset, and save cycles. Assert each key is removed
from the persisted partial configuration and that Config.parse restores its
corresponding default, preserving coverage of the shared None bypass across all
coercion branches.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/unit/test_config.py`:
- Around line 87-98: Extend test_unset_numeric_key to also unset and verify a
float field and a Path field, covering their set, save, unset, and save cycles.
Assert each key is removed from the persisted partial configuration and that
Config.parse restores its corresponding default, preserving coverage of the
shared None bypass across all coercion branches.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f7debedf-6bde-40b8-bab9-3ba2dd034d2b

📥 Commits

Reviewing files that changed from the base of the PR and between 8a97c79 and 1554f95.

📒 Files selected for processing (2)

• secator/config.py
• tests/unit/test_config.py

[ocervell]

Thanks for this ! I just came back from vacations, will test this shorty and if all good add it to the next release ;)