Skip to content

fix(command): authoritative sudo required #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpce-it-dis-soc-sof wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −3
Open

fix(command): authoritative sudo required #1295

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0ff0ab
fix(command): authoritative sudo required
bpce-it-dis-soc-sof Jul 8, 2026
80099f4
fix: lint
bpce-it-dis-soc-sof Jul 8, 2026
b04e485
fix: requires_sudo instead of sudo_required
bpce-it-dis-soc-sof Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions secator/runners/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,8 @@ def yielder(self):
self.print_command()

# Check for sudo requirements and prepare the password if needed
sudo_required = re.search(r'\bsudo\b', self.cmd)
sudo_password = None
if CONFIG.security.prompt_sudo_password and sudo_required:
if CONFIG.security.prompt_sudo_password and self.requires_sudo:
self.debug('prompting for sudo password', sub='start')
sudo_password, error = self._prompt_sudo(self.cmd)
if error:
Expand Down Expand Up @@ -544,7 +543,7 @@ def yielder(self):
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
universal_newlines=True,
preexec_fn=os.setsid if not (sudo_required or self.disable_preexec) else None,
preexec_fn=os.setsid if not (self.requires_sudo or self.disable_preexec) else None,
shell=self.shell,
errors='replace',
env=env,
Expand Down
Loading