Feature: Add IPv6 support#69
Open
adjivas wants to merge 3 commits into
Open
Conversation
added 2 commits
August 18, 2025 10:30
xchux
reviewed
May 10, 2026
Comment on lines
+147
to
+165
| if s.BindingIP == "" && s.BindingIPv4 != "" { | ||
| s.BindingIP = s.BindingIPv4 | ||
| } | ||
| if s.RegisterIP == "" && s.RegisterIPv4 != "" { | ||
| s.RegisterIP = s.RegisterIPv4 | ||
| } | ||
|
|
||
| // Set a default BindingIP/RegisterIP if the Configuration does not provides them | ||
| if s.BindingIP == "" && s.RegisterIP == "" { | ||
| s.BindingIP = NrfSbiDefaultIP | ||
| s.RegisterIP = NrfSbiDefaultIP | ||
| } else { | ||
| // Complete any missing BindingIP/RegisterIP from RegisterIP/BindingIP | ||
| if s.BindingIP == "" { | ||
| s.BindingIP = s.RegisterIP | ||
| } else if s.RegisterIP == "" { | ||
| s.RegisterIP = s.BindingIP | ||
| } | ||
| } |
There was a problem hiding this comment.
How about the following approach? It reduces duplicated values, which helps avoid confusion.
// fallback to IPv4 fields
if s.BindingIP == "" {
s.BindingIP = s.BindingIPv4
}
if s.RegisterIP == "" {
s.RegisterIP = s.RegisterIPv4
}
// set defaults / complete missing values
switch {
case s.BindingIP == "" && s.RegisterIP == "":
s.BindingIP = NrfSbiDefaultIP
s.RegisterIP = NrfSbiDefaultIP
case s.BindingIP == "":
s.BindingIP = s.RegisterIP
case s.RegisterIP == "":
s.RegisterIP = s.BindingIP
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.