Inline <style> and <link> support#2
Open
FurryR wants to merge 2 commits into
Open
Conversation
Currently, `<link>` use a workaround to prevent complex process during parsing stage. No CSS3 `@import` support is provided. I imported `requests` for the implementation of the default fetcher; it's probably unnecessary. If needed, the `request` dependency can be removed, in this case `<link>` support will be disabled. Signed-off-by: FurryR <awathefox@gmail.com>
Signed-off-by: FurryR <awathefox@gmail.com>
Author
|
If necessary, you can cherry-pick the first commit if you wish to import requests as default fetcher. Test cases / Changelog / Examples is not ready for the new feature, while author information is also not updated. If necessary you may update them manually. |
Owner
|
Hey @FurryR :) Thanks for opening this PR. I will review it in the next days and let you know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1.
Caveat
<link>, CSS3@importsyntax is not supported (there's also problems on URL handling). However it is unable to fix the caveat without making REALLY huge changes, so I will just leave it. Maybe you should add a todo for it.Relevant possibly incompatible changes
My package manager is unable to resolve all the dependencies under Python version
>=3.8. I bumped it to>=3.9for fix. This may result in incompatibility.Detailed output (pdm):
.gitignoreis changed slightly to work with PDM. This should work fine with previous versions.