Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlignedStream.read()with no size reads from the aligned offset rather thanthe current position, so it returns the wrong bytes and leaves
tell()pastthe real end of the stream.
This is visible through
RelativeStream, which documents support for readingwithout a size. On a 32 byte stream,
seek(10)followed byread()returns32 bytes starting at offset 0 instead of the 22 bytes from offset 10, and
tell()ends up at 42.Slice the leading bytes off the aligned read so both the buffered and
unbuffered paths return data from the current position, and track the final
position from what was actually returned.
Found while fixing #114, and filed separately since it is a distinct bug in
the base class rather than in
OverlayStream.Fixes #135
Test plan
tox run -e py3passes (160 passed)the public
RelativeStreamAPI